Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Multi)polygon fixing effort #3908

Closed
joto opened this issue Mar 17, 2017 · 2 comments
Closed

(Multi)polygon fixing effort #3908

joto opened this issue Mar 17, 2017 · 2 comments

Comments

@joto
Copy link

joto commented Mar 17, 2017

There is a major effort going on to fix broken (multi)polygons in OSM and also to finally get rid of old-style multipolygon relations. This will hopefully lead to simpler and more efficient software. There is no immediate need for you to change anything in iD, but I would expect there to be opportunities to simplify your code and generally make life easier for you once this effort is successful.

I wanted to make you aware of the effort and get you involved in the discussions. We'd also appreciate it if you can support this effort in any way. Find all the details at http://area.jochentopf.com/. We are coordinating with other software project through our issue osmlab/fixing-polygons-in-osm#23.

@bhousel
Copy link
Member

bhousel commented Mar 21, 2017

This is great news! I really like the stats page.

iD supports either old or new style multipolygons for rendering, and iD creates only the new style multipolygons when merging areas or ways, so I agree there probably isn't anything for us to do, and I'll close this here.

It looks like new-style multipolygons would get a slight performance bump in iD, because osmIsSimpleMultipolygonOuterMember would exit early, avoiding the ring checking and tag merging code.

@bhousel
Copy link
Member

bhousel commented Apr 21, 2017

Update on this: I decided to render the old-style multipolygons slightly differently. Hopefully it won't bother anyone, and there will be fewer of these over time.

If you see shape like this with little holes along the edge, it's an old multipolygon and you should fix it if you know how. 😁

screenshot 2017-04-20 23 28 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants