Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research needed for: shop/convenience|Alimentara #1246

Closed
bhousel opened this issue Oct 16, 2018 · 0 comments · Fixed by #2488
Closed

Research needed for: shop/convenience|Alimentara #1246

bhousel opened this issue Oct 16, 2018 · 0 comments · Fixed by #2488
Labels
generic name Actionable - filter out a generic name

Comments

@bhousel
Copy link
Member

bhousel commented Oct 16, 2018

🤔 We need help deciding what to do with "shop/convenience|Alimentara"

👉 Read the CONTRIBUTING.md guide for more info, and feel free to ask questions on this issue!

What's needed

First, do some research on shop/convenience|Alimentara by searching Google and Wikipedia.

If it is an actual brand:

  • Edit config/canonical.json:
    • Find the entry for shop/convenience|Alimentara
    • Add tags for brand:wikidata and brand:wikipedia
    • Optionally add "countryCodes" or other tags
  • npm run build
  • Commit your changes and submit a pull request

If it is not an actual brand:

  • Edit config/filters.json to add an expression that discards it
  • Edit config/canonical.json to remove the entry for shop/convenience|Alimentara
  • npm run build
  • Commit your changes and submit a pull request

If the situation is complicated:

  • Leave a comment on this issue with what you find

✨ Thanks!

This is an autogenerated ticket

@bhousel bhousel added good first issue Best for first-time contributors. No experience necessary! Hacktoberfest labels Oct 16, 2018
@Adamant36 Adamant36 added invalid generic name Actionable - filter out a generic name labels Jan 22, 2019
@Adamant36 Adamant36 removed the good first issue Best for first-time contributors. No experience necessary! label Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic name Actionable - filter out a generic name
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants