Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discard generic names #2488

Merged
merged 1 commit into from
Mar 18, 2019
Merged

discard generic names #2488

merged 1 commit into from
Mar 18, 2019

Conversation

Adamant36
Copy link
Collaborator

I don't think I've discarded generics before. So let me know if I did anything wrong and I'll fix it. Closes #1491, closes #1258, closes #1249, closes #1248, closes #1247, closes #1246, closes #815, closes #814, closes #806, closes #465

@matkoniecz
Copy link
Contributor

matkoniecz commented Mar 18, 2019

Are names discarded here just not brand names or are also ones that should not be never used in the name tag?

In other words - is it something like "tourism=hotel name=hotel or tourism=hotel name=Victoria"?

discardNames is also unfortunately directly used by iD (rather than using their own list) and this editor will encourage people to delete tags listed here. To avoid this one may add names to discardKeys that are not brands but can be used.

See openstreetmap/iD#5930 and openstreetmap/iD#6055

@Adamant36
Copy link
Collaborator Author

As far as I know they are generic like tourism=hotel name=hotel. 99% of the generic names are like that and not the second example. I know because I added most of the labels and intentionally avoided adding them to ones that were like it.

Looking over them though, Figaro means barber, Delikatesy means delicatessen, Baqala means "what comes out of the ground" and all grocery stores in Abu Dhabi is named that for some odd reason, Bakkal means grocer, Alimentari means food, Alimentara essentially means the same thing, Comida china means "Chinese restaurant" in Spanish, Comedor means "dining room" or "restaurant", Chifa is a Chinese Cantonese style of food, benzina means "fuel." I think that covers it and that they can all be discarded, along with being filtered out or whatever.

Btw, I know how the index integrates with iD Editor. I was the one that opened the issue suggesting iD Editor use it as a way to suggest people not use generic terms for the name tag.

@matkoniecz matkoniecz merged commit 8bbc027 into osmlab:master Mar 18, 2019
@matkoniecz
Copy link
Contributor

In that case everything looks fine.

@Adamant36
Copy link
Collaborator Author

In that case everything looks fine.

Cool. Thanks for merging it.

@tohaklim
Copy link
Collaborator

tohaklim commented Aug 5, 2019

By no means an authority on this, but is Delikatesy really should be discouraged? I thought something like "Spozywczy" might be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment