Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix damage in OSM caused by a bogus match (Citizens Bank linked to entry about a specific building) #2769

Closed
matkoniecz opened this issue Jun 8, 2019 · 3 comments
Closed

Fix damage in OSM caused by a bogus match (Citizens Bank linked to entry about a specific building) #2769

matkoniecz opened this issue Jun 8, 2019 · 3 comments
Assignees
@matkoniecz
Labels
fix data Need to cleanup the data in OSM after this is released

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Jun 8, 2019 •
edited
Loading

Mismatch fixed in e8ad03a

Preferably to be done after release so iD is not adding new mismatches (I can do it, I have a bot used in a previous fix).

All brand:wikidata and brand:wikipedia in http://overpass-turbo.eu/s/JM5 probably should be removed

Added in d1cb033e4 - looks like an unfortunate mistake
@matkoniecz matkoniecz changed the title Fix damage in OSM caused by a bogus match Fix damage in OSM caused by a bogus match (Citizens Bank linked to entry about a specific building) Jun 8, 2019
This was referenced Jun 8, 2019
Closed
Closed
@bhousel
Copy link
Member

bhousel commented Jun 8, 2019

We should really fix the index too, if there are several Citizen's Banks.
https://en.wikipedia.org/wiki/Citizens_Bank

We can just multiple entries with disambiguation text and then iD won't suggest upgrades in those cases.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Jun 8, 2019 •
edited
Loading

We should really fix the index too

after e8ad03a it will no longer be in distributed version, though yes - it appears to be more than one institution using this name and it should be covered by the index

bhousel added a commit that referenced this issue Jun 10, 2019
@bhousel
Disambiguate various Citizen Banks
12198fa 
(re: #2769)
@bhousel bhousel added the fix data Need to cleanup the data in OSM after this is released label Jun 14, 2019
@matkoniecz matkoniecz self-assigned this Jun 21, 2019
@matkoniecz
Copy link
Contributor Author

matkoniecz commented Jun 21, 2019 •
edited
Loading

New version released ( https://github.com/osmlab/name-suggestion-index/releases ), iD is updated - openstreetmap/iD#6543

I will now run fix edit, removing all "brand:wikidata": "Q25209674", "brand:wikipedia": "en:Citizens Bank (South Bend, Indiana)".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matkoniecz matkoniecz

Labels
fix data Need to cleanup the data in OSM after this is released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhousel @matkoniecz