Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amenity=post_box with name=* #3410

Closed
Recoil016 opened this issue Nov 30, 2019 · 5 comments
Closed

amenity=post_box with name=* #3410

Recoil016 opened this issue Nov 30, 2019 · 5 comments
Labels
considering Not Actionable - still considering if this is something we want

Comments

@Recoil016
Copy link
Contributor

According to the Wiki, amenity=post_box should have the operator tagged in the operator=* tag, not the name=* tag (which makes sense, since postboxes usually do not have a name). This is currently not the case, thereby leading to post boxes tagged with a name when using the NSI and not double-checking the suggested tagging.

@bhousel
Copy link
Member

bhousel commented Nov 30, 2019

Can you link to the wiki page where you found this? Many times the wiki just reflects one person's opinions about how post boxes should be tagged. It's really not a "spec". I personally don't have a problem with postboxes that have UPS, FedEx, USPS, or whatever in the name field, and renderers are free to skip labels for those features.

If the entry made it into this index in the first place, it's because our scripts did find the name used frequently enough in the name tag for it to get included. (> 50 times)

Still, if people really are upset about names on post boxes, we can remove them from NSI like we did with the nextbike entries in #3378.

Let's discuss, but not just assume the wiki is right (it often isn't).

@bhousel bhousel added the considering Not Actionable - still considering if this is something we want label Nov 30, 2019
@Recoil016
Copy link
Contributor Author

Recoil016 commented Nov 30, 2019

The wiki page here shows as tagging scheme to use the operator (aka. the mail service responsible) in the operator=* tag, it does not discuss the name=* tag at all.

My argument is more about general mapping practice, really and thought the Wiki was an accepted backup for that.

Since it apparently isn't have some data: This overpass query for the German state of North-Rhine Westphalia (as an example) shows 4400 nodes with operator="Deutsche Post" whereas this query with name="Deutsche Post" only returns 34 nodes. At least for Germany, this is considered mapping practice.

Taginfo seems to also back this up: https://taginfo.openstreetmap.org/tags/amenity=post_box#combinations

I just think it is factually wrong. At least in Germany, postboxes do not have names, they have a ref=* at most, and well, the operator that runs them.

@bhousel
Copy link
Member

bhousel commented Nov 30, 2019

Ok, you convinced me.. I removed the post boxes in 0de5108. I didn't realize people were so uptight about seeing name tags on them.

Let me know if you find anything else in our index that you want removed.

@Recoil016
Copy link
Contributor Author

Please be aware that I never meant to have the post boxes removed from the index, I just wanted to point to the idea that maybe the "name" should be moved to the "operator".

@bhousel
Copy link
Member

bhousel commented Nov 30, 2019

Please be aware that I never meant to have the post boxes removed from the index, I just wanted to point to the idea that maybe the "name" should be moved to the "operator".

That's ok! We can put them back once the code is set up to work with operator tags. They've been gone since #2816, but we know there are some situations where they make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
considering Not Actionable - still considering if this is something we want
Projects
None yet
Development

No branches or pull requests

2 participants