Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home timber and hardware australia #2777

Merged
merged 2 commits into from
Jun 10, 2019

Conversation

andrewharvey
Copy link
Collaborator

@andrewharvey andrewharvey commented Jun 10, 2019

see also openstreetmap/iD#6513 where iD suggested the wrong brand tags

@Adamant36
Copy link
Collaborator

Adamant36 commented Jun 10, 2019

You don't need a match for "home hardware" if it's already used as the alt name. The name index accounts for capitalizing and searches alt name for matches now.

I'm kind of wondering about the usage of "home" to. It seems a little to general to me. Even if the business goes by that somewhere. There's a bunch of places named "home" all over the world.

@andrewharvey
Copy link
Collaborator Author

You don't need a match for "home hardware" if it's already used as the alt name. The name index accounts for capitalizing and searches alt name for matches now.

Sorry you're right.

I'm kind of wondering about the usage of "home" to. It seems a little to general to me. Even if the business goes by that somewhere. There's a bunch of places named "home" all over the world.

According to Wikipedia "Home" is a common name, and based on my experience Home is a valid short name.

Home Timber & Hardware (commonly known as "Home" or "Home Hardware")

I'm wondering if it matter if there are other places also named Home? Upstream consumers of name-suggestion-index know that this should only match in au, and a user should still review any tag suggestions to make sure they are correct to add to the feature.

@matkoniecz
Copy link
Contributor

Looking at http://overpass-turbo.eu/s/JPR and its Wikipedia page it seems that shop=hardware may also match.

Is shop=doityourself better for all its locations?

@bhousel
Copy link
Member

bhousel commented Jun 10, 2019

Looks good thanks @andrewharvey 👍

@bhousel bhousel merged commit 5af0e03 into osmlab:master Jun 10, 2019
@andrewharvey
Copy link
Collaborator Author

Looking at http://overpass-turbo.eu/s/JPR and its Wikipedia page it seems that shop=hardware may also match.

Is shop=doityourself better for all its locations?

I did review the wiki page for shop=hardware and shop=doityourself. The distinction is blury, but from my understanding hardware was for small shops selling screws, nails etc. whereas doityourself was for larger shops selling a wider range of products, for the kitchen, bathroom, etc.

@Adamant36
Copy link
Collaborator

I agree the difference is blurry. In the description section for shop=hardware it says its for a "shop which sells timber, tools and other building products." That sounds more like a diy store to me. The specific mention of timber is what makes me thing this should be tagged as a hardware store. Either that or the related wiki pages should be updated to be more clear about what exactly the tags apply to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants