-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
home timber and hardware australia #2777
Conversation
You don't need a match for "home hardware" if it's already used as the alt name. The name index accounts for capitalizing and searches alt name for matches now. I'm kind of wondering about the usage of "home" to. It seems a little to general to me. Even if the business goes by that somewhere. There's a bunch of places named "home" all over the world. |
Sorry you're right.
According to Wikipedia "Home" is a common name, and based on my experience Home is a valid short name. Home Timber & Hardware (commonly known as "Home" or "Home Hardware") I'm wondering if it matter if there are other places also named Home? Upstream consumers of name-suggestion-index know that this should only match in |
Looking at http://overpass-turbo.eu/s/JPR and its Wikipedia page it seems that Is |
Looks good thanks @andrewharvey 👍 |
I did review the wiki page for shop=hardware and shop=doityourself. The distinction is blury, but from my understanding hardware was for small shops selling screws, nails etc. whereas doityourself was for larger shops selling a wider range of products, for the kitchen, bathroom, etc. |
I agree the difference is blurry. In the description section for shop=hardware it says its for a "shop which sells timber, tools and other building products." That sounds more like a diy store to me. The specific mention of timber is what makes me thing this should be tagged as a hardware store. Either that or the related wiki pages should be updated to be more clear about what exactly the tags apply to. |
see also openstreetmap/iD#6513 where iD suggested the wrong brand tags