Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Chrysler, Proton, Saipa #2955

Merged
merged 2 commits into from
Aug 11, 2019
Merged

Adding Chrysler, Proton, Saipa #2955

merged 2 commits into from
Aug 11, 2019

Conversation

bkissin
Copy link
Contributor

@bkissin bkissin commented Aug 9, 2019

No description provided.

brands/shop/car.json Outdated Show resolved Hide resolved
@mds08011 mds08011 merged commit bb5a427 into osmlab:master Aug 11, 2019
@mds08011
Copy link
Collaborator

Thank you!

@Adamant36
Copy link
Collaborator

Are there actually "Chrysler" stores out there? I know there's places that sell sell Chryslers, but do they have their own self branded stores just called "Chrysler"?

@1ec5
Copy link
Member

1ec5 commented Aug 12, 2019

It’s the same as with any other American car brand that has a dealership network. Chrysler is usually combined with other brands owned by the company (Jeep, Dodge, and Ram), but I’d expect for there to be entries for those brands too.

@Adamant36
Copy link
Collaborator

It's not really the name of the car dealership though (in this case I assume it would be "Something Something Chrysler Jeep Whatever"). I feel like in cases like this there should be a carbrand=* tag that's used instead and then stores are tagged with the local name. It shouldn't be assumed that all car dealerships with "Chrysler" signs out front are corporate though or shouldn't be tagged with the local dealerships name. Which you usually can't tell just with drive by sign tagging.

@bkissin
Copy link
Contributor Author

bkissin commented Aug 12, 2019

I definitely get where @Adamant36 is coming from, which is why I was hesitant to add the other brands under the same umbrella corporation. With the exception of VW group brands (VW, SEAT, Skoda, Audi, etc.) many multi-brand automakers (partially because they often group brands together at dealerships) are not listed in the index. I don't know whether it would make sense to create individual entries for Dodge, Jeep, etc. unless there was an option to add multiple brands under the brand= section.

That being said, there is certainly a way to tag the brand, but keep the local name. Usually when I'm in iD, I'll update the tag, and then change the name from "Rimouski Honda" to "Honda" in order to activate the brand info, and then go back into the name section and re-add the local name information.

@bhousel
Copy link
Member

bhousel commented Aug 12, 2019

per #2847 I'd prefer to avoid combining brands in the index for now.

It's totally ok if mappers want to add several points and either leave them separate or merge them together (creating semicolon-delimited values), or if mappers want to adjust the name tag to say "Whatever Honda". iD supports both of these things.

@1ec5
Copy link
Member

1ec5 commented Aug 12, 2019

Car brands were one of the original use cases for the brand tag. The dealerships I have in mind are the ones whose monument signs are emblazoned with the Chrysler, Jeep, and Dodge logos and nothing else. I’m not referring to, say, used car dealerships that happen to carry Chrysler cars but are unaffiliated with that company. Whether an authorized dealer is corporate or franchised is a concern for operator, not brand.

It is the case that car dealerships usually have something else in the name, signage notwithstanding. We should encourage mappers to add this detail, but location-specific names are never by themselves a reason to omit entries from this index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants