Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created "post_box.json" for operator #4646

Closed
wants to merge 2 commits into from
Closed

Created "post_box.json" for operator #4646

wants to merge 2 commits into from

Conversation

UKChris-osm
Copy link
Collaborator

Created "post_box.json" (operator), starting with Royal Mail.

Created "post_box.json" within operators, starting with post box's operated by Royal Mail (UK).
Added Post Box to keepTags
@bhousel
Copy link
Member

bhousel commented Nov 4, 2020

This seems pretty good..
I was actually thinking of making the post_box category "automatic" kind of like what we were discussing on the ATM ticket (#2883). This isn't a thing yet, but I could hack it together tomorrow probably? What do you think?

@UKChris-osm
Copy link
Collaborator Author

UKChris-osm commented Nov 5, 2020

When you say automatic, do you mean auto-generating a file with many data points for post box's around the world, in the same way you had done for transit? At which point we could add wikidata and locationSet after? I'm happy with that method and think it would move the project along much more quickly 👍

@bhousel
Copy link
Member

bhousel commented Nov 5, 2020

auto-generating a file with many data points for post box's around the world,

Yes sort of.. I'm thinking of a rule that generates a amenity=post_box item for every amenity=post_office item.

@UKChris-osm
Copy link
Collaborator Author

Are you thinking of auto-populating the post box data (operator) with post office data (operator)?

@UKChris-osm UKChris-osm marked this pull request as draft November 5, 2020 19:09
@bhousel
Copy link
Member

bhousel commented Nov 5, 2020

Are you thinking of auto-populating the post box data (operator) with post office data (operator)?

yes, exactly! 👍

@UKChris-osm
Copy link
Collaborator Author

My only concern in that would be the population of Post Office data in to Post Boxes which are operated by other entities.

In the UK for example, the UK Post Office doesn't operate the post boxes, the Royal Mail do.

This wouldn't be an issue for the UK as I can happily update the entry pretty quickly, but I'm not sure how other Countries operate?

Would you be able to build the script to compare current operator data assigned to post boxes to see if they match post office data before populating the NSI, for example:

  • check post boxes in each Country for any pre-existing operator data.
  • if found, does this data match the post office operator?
  • if yes, populate, if not, leave blank!
  • if multiple operator data points are found, leave blank!

Does that make sense?

@UKChris-osm
Copy link
Collaborator Author

Closing so @bhousel can implement automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants