Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for amenity/library in operator tree #5526

Merged
merged 12 commits into from
Oct 19, 2021
Merged

Conversation

arch0345
Copy link
Collaborator

This is similar to other categories I've added to the index in the past: amenity/school and leisure/park.

There are many public operators of libraries that operate multiple locations (at least in the US), so adding this category in the index could be beneficial. So far the only entry I've completed is the New York Public Library, but it looks like a lot more have been collected from the latest planet file.

@arch0345 arch0345 added the new category Add support for a new kind of feature label Oct 18, 2021
@1ec5
Copy link
Member

1ec5 commented Oct 19, 2021

There are many public operators of libraries that operate multiple locations (at least in the US), so adding this category in the index could be beneficial.

Agreed, Wikidata even imported a database of over 17,000 U.S. library systems and branch locations, so there’s a lot of room for this tree to expand (and for individual branches to be tagged). Alas, it’s probably too late for @bhousel to spin up another massive Hacktoberfest issue series around these library systems.

Copy link
Collaborator

@LaoshuBaby LaoshuBaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this amendment, because many times libraries appear in groups, especially when the government or some charitable organizations form groups to improve cultural and educational conditions.

LaoshuBaby and others added 10 commits October 19, 2021 14:06
looks like there are English,Germany,Spanish,and I don't know
But they are......I think......are all univ.
The Public Library of Cincinnati and Hamilton County recently rebranded as the Cincinnati and Hamilton County Public Library.
@bhousel
Copy link
Member

bhousel commented Oct 19, 2021

Good idea! 👍

Alas, it’s probably too late for @bhousel to spin up another massive Hacktoberfest issue series around these library systems.

Yes I think it's too late to promote it widely, but not too late to send in 4 PRs and earn some swag 👕 or plant a tree 🌱

@bhousel bhousel merged commit b0b6101 into main Oct 19, 2021
@bhousel bhousel deleted the arch0345-libraries branch October 19, 2021 14:33
@LaoshuBaby LaoshuBaby mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new category Add support for a new kind of feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants