Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post offices and related items need to be in the brands tree, not the operators tree #5613

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

bhousel
Copy link
Member

@bhousel bhousel commented Oct 31, 2021

This PR moves the post offices from the operators tree back to the brands tree.

This fixes the situation for Poste Norge and Post Office (and probably others) where they are really brands that have independently operated locations. This also more closely matches the current guidance on the OSM wiki for tagging post offices.

closes #5564
closes #5561
closes #5446

@bhousel bhousel merged commit 610ba04 into main Oct 31, 2021
@bhousel bhousel deleted the post_offices_are_brands branch October 31, 2021 18:58
bhousel added a commit that referenced this pull request Oct 31, 2021
@@ -1,6 +1,6 @@
{
"properties": {
"path": "operators/amenity/post_box",
"path": "brands/amenity/post_box",
Copy link
Member

@1ec5 1ec5 Oct 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear, #5561 (comment) described an edit to the amenity=post_office documentation that should’ve had little bearing on amenity=post_box. Conversely, these features were originally moved from the brands tree to the operators tree in response to feedback in #4925, but that feedback was about amenity=post_box, not amenity=post_office.

I think the back and forth is because post offices and postboxes are being treated identically. But it seems like the expectation – most of the time – is that post offices need the distinction between brands and operators more than postboxes do. Contract post offices are a widespread phenomenon in many countries, but contract postboxes would be much more of an edge case.

(I did argue in gravitystorm/openstreetmap-carto#1023 that postboxes should be labeled based on their operators, but that was before I learned about brand and before it had become common on postal facilities in the U.S.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok - If I'm reading your comment correctly, it sounds like amenity/post_box should remain in operators tree? That seems ok to me.

@bhousel
Copy link
Member Author

bhousel commented Nov 1, 2021

I ended up reverting this PR, there is some investigation on #5613 and I'm now convinced that we can have a category like amenity/post_office that has some items in the operators tree and some in the brands tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posten Norge Incorrect operator tags for UK Post Offices
2 participants