Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new parcel lockers #7140

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Conversation

serhii-muchychka
Copy link
Collaborator

According to the wiki, the name tag is discouraged, so I haven't added it yet and will wait for advice
https://wiki.openstreetmap.org/wiki/Tag:amenity%3Dparcel_locker

@bhousel
Copy link
Member

bhousel commented Oct 5, 2022

Those edits to discourage the name tag on the wiki were made just in the past week, by wiki editors who I dont recognize.
https://wiki.openstreetmap.org/w/index.php?title=Tag%3Aamenity%3Dparcel_locker&type=revision&diff=2411122&oldid=2402396

I really wish people wouldn't do this.

@serhii-muchychka
Copy link
Collaborator Author

So, based on the previous NSI data and the fact that the wiki information are not fully discussed, it is OK to add the name

@arch0345 arch0345 merged commit 574cc54 into osmlab:main Oct 8, 2022
@1ec5
Copy link
Member

1ec5 commented Oct 8, 2022

Those edits to discourage the name tag on the wiki were made just in the past week, by wiki editors who I dont recognize. https://wiki.openstreetmap.org/w/index.php?title=Tag%3Aamenity%3Dparcel_locker&type=revision&diff=2411122&oldid=2402396

Of these two edits, one is consistent with the amenity=parcel_locker proposal that was approved, though I didn’t notice that detail until now. Apparently the idea was to make it similar to ATM tagging.

The other edit is talking about putting the locker’s unique identifier in ref instead of name. This seems consistent with how NSI prefers to put individual store location names in branch instead of name in most cases.

@bhousel
Copy link
Member

bhousel commented Oct 8, 2022

We've discussed this extensively in the past and the name of these Amazon Lockers was always formatted a certain way, at least back in 2020 - 2021 , prior to the introduction of the parcel locker tag. I even adjusted how NSI code works based on the Amazon Locker issue, and based on how other more mainstream maps display these features.

#3748
openstreetmap/iD#8305 (comment)
openstreetmap/iD#8305 (comment)
#4902 (comment)

For ATMs we do the same thing. Plenty of legacy renderers still use the name tag as a display string:
46ab8eb#commitcomment-44125210
#2883 (comment)
#5338

The most important thing is - people should participate in the discussions we already have rather than just changing the wiki. If having a name tag on a vending machine causes actual problems for anyone making a map, I'd love to hear it.

@serhii-muchychka serhii-muchychka deleted the parcel-lockers branch October 13, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants