Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed name tag for IGA (Australia) #7578

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Conversation

Scottie0001
Copy link
Contributor

IGA stores across Australia trade under many different names however they are all part of IGA (Australia).

IGA stores across Australia trade under many different names however they are all part of IGA (Australia)
@@ -3175,7 +3175,6 @@
"tags": {
"brand": "IGA",
"brand:wikidata": "Q5970945",
"name": "IGA",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in new POIs with this brand having no name by default. Is it incorrect or only suboptimal to tag it with a name of “IGA”?

To keep “IGA” as the default name but allow the user to easily modify an individual location’s name, keep the name but add a preserveTags to the entry instead:

"preserveTags": ["^name"],

This will keep the Name field unlocked and suppress the warning that currently occurs when you change the name away from “IGA” to something more specific. This change would be equally applicable to IGA in the United States: #5500 (comment).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the intended result.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would be equally applicable to IGA in the United States: #5500 (comment).

dda2181 applies the same to the IGA entry for North America.

@LaoshuBaby LaoshuBaby merged commit 511b07b into osmlab:main Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants