Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #524

Merged
merged 163 commits into from
May 31, 2022
Merged

Update #524

merged 163 commits into from
May 31, 2022

Conversation

danieldegroot2
Copy link
Contributor

@danieldegroot2 danieldegroot2 commented Apr 1, 2022

(Submitted with GitHub browser version); Validate manually.

Initial commit to update some community resources.

Copy link
Member

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks mostly good! let me know when you're finished and I'll merge it 👍

resources/europe/united_kingdom/aberdeen-discord.json Outdated Show resolved Hide resolved
@danieldegroot2
Copy link
Contributor Author

@bhousel Ready.

@bhousel bhousel merged commit 6913ac2 into osmlab:main May 31, 2022
@bhousel
Copy link
Member

bhousel commented May 31, 2022

Ok Thanks again @danieldegroot2 - I just cleaned up the remaining few syntax errors and merged this.. Going forward please try to keep your pull requests small, and don't rewrite your comments - this makes it really hard for people to follow what you are doing.

I also really encourage you to set up a local development environment and get in the habit of running npm run build sometimes, as this will check the files for syntax errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants