Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to github #25

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Add link to github #25

wants to merge 1 commit into from

Conversation

tordans
Copy link

@tordans tordans commented Aug 5, 2020

Add a footer that links to this repo, so it can be easily found from the website.
Also extract the #history-div that is used by JS, so the footer does get in its way.

It looks like this:
image

Add a footer that links to this repo, so it can be easily found from the website.
Also extract the #history-div that is used by JS, so the footer does get in its way.
@iandees
Copy link
Member

iandees commented Aug 5, 2020

I like the idea of linking to the GitHub repo, but having it under the tag list makes it look like it's part of the OSM data. Can it be moved up to the header? Maybe in the upper right corner?

@tordans
Copy link
Author

tordans commented Aug 5, 2020

On my screen (width) that would be cluttered and could be interpreted as part of the header.

I thought the footer-gray styling makes it different enough to not be confused as content.

But maybe an icon instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants