-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new proto annotations exist upstream #400
Comments
Okay you got it sir |
@faddat — can you cherry pick the annotations? I think @ValarDragon was suggesting we want to cherry pick only portions from cosmos#13501 @ValarDragon can you describe what code we do and don't want from that PR? |
totally. I'll see what I can do rn this? |
yea that one! |
Agreed with just taking amino.proto from the original PR! |
@faddat so yea this should make it simple then ^^ |
@pyramation Do you know if the new way of amino annotations is compatible with the current way of handling amino? |
@mattverse there are no actual changes as far as functionality or Go is concerned. However, the annotations do enable us to do many things after we have them in place! |
this is needed to use the new transpiler that will solve a ton of client side amino encoding for Very useful also for RPC — e.g. pools and their types magically decoded! cc @faddat @mattverse @ValarDragon Can we open this issue back up? |
This PR added amino annotations for codegen.
If we don't want to take the entire PR, I suggest we at least add this proto file
this PR in Osmosis depends on this issue
The text was updated successfully, but these errors were encountered: