Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new proto annotations exist upstream #400

Closed
pyramation opened this issue Dec 18, 2022 · 9 comments · Fixed by #412
Closed

new proto annotations exist upstream #400

pyramation opened this issue Dec 18, 2022 · 9 comments · Fixed by #412
Labels

Comments

@pyramation
Copy link

pyramation commented Dec 18, 2022

This PR added amino annotations for codegen.

If we don't want to take the entire PR, I suggest we at least add this proto file

this PR in Osmosis depends on this issue

@faddat
Copy link
Member

faddat commented Dec 18, 2022

Okay you got it sir

@pyramation
Copy link
Author

@faddat — can you cherry pick the annotations? I think @ValarDragon was suggesting we want to cherry pick only portions from cosmos#13501

@ValarDragon can you describe what code we do and don't want from that PR?

@faddat
Copy link
Member

faddat commented Dec 27, 2022

totally. I'll see what I can do rn

this?

cosmos@b49f948

@pyramation
Copy link
Author

totally. I'll see what I can do rn

this?

cosmos@b49f948

yea that one!

@mattverse
Copy link
Member

Agreed with just taking amino.proto from the original PR!

@pyramation
Copy link
Author

Agreed with just taking amino.proto from the original PR!

@faddat so yea this should make it simple then ^^

@mattverse
Copy link
Member

@pyramation Do you know if the new way of amino annotations is compatible with the current way of handling amino?

@pyramation
Copy link
Author

@pyramation Do you know if the new way of amino annotations is compatible with the current way of handling amino?

@mattverse there are no actual changes as far as functionality or Go is concerned. However, the annotations do enable us to do many things after we have them in place!

@pyramation
Copy link
Author

this is needed to use the new transpiler that will solve a ton of client side amino encoding for google.protobuf.Any types. Will be very useful for governance MsgSubmitProposal, as well as authz when 0.47 comes out — full amino support for any message!

Very useful also for RPC — e.g. pools and their types magically decoded!

cc @faddat @mattverse @ValarDragon

Can we open this issue back up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants