feat: Add proto annotations for amino json #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
changed the title
|
LGTM! |
|
Hey @mattverse . Can you please look into conflicts here when you have time? |
|
Merging this once CI is passing |
|
🙌🏻 |
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2023
(cherry picked from commit c3a425b) # Conflicts: # crypto/keys/ed25519/keys.pb.go # crypto/keys/multisig/keys.pb.go # crypto/keys/secp256k1/keys.pb.go # scripts/protocgen.sh # types/coin.pb.go # types/tx/amino/amino.pb.go # x/auth/types/auth.pb.go # x/auth/types/genesis.pb.go # x/auth/vesting/types/tx.pb.go # x/authz/authz.pb.go # x/authz/genesis.pb.go # x/authz/tx.pb.go # x/bank/types/authz.pb.go # x/bank/types/bank.pb.go # x/bank/types/genesis.pb.go # x/bank/types/query.pb.go # x/bank/types/tx.pb.go # x/capability/types/capability.pb.go # x/capability/types/genesis.pb.go # x/crisis/types/genesis.pb.go # x/crisis/types/tx.pb.go # x/distribution/types/distribution.pb.go # x/distribution/types/genesis.pb.go # x/distribution/types/query.pb.go # x/distribution/types/tx.pb.go # x/evidence/types/evidence.pb.go # x/evidence/types/tx.pb.go # x/feegrant/feegrant.pb.go # x/feegrant/genesis.pb.go # x/feegrant/tx.pb.go # x/genutil/types/genesis.pb.go # x/gov/types/genesis.pb.go # x/gov/types/gov.pb.go # x/gov/types/query.pb.go # x/gov/types/tx.pb.go # x/mint/types/genesis.pb.go # x/mint/types/mint.pb.go # x/mint/types/query.pb.go # x/params/types/proposal/params.pb.go # x/params/types/proposal/query.pb.go # x/slashing/types/genesis.pb.go # x/slashing/types/query.pb.go # x/slashing/types/slashing.pb.go # x/slashing/types/tx.pb.go # x/staking/types/authz.pb.go # x/staking/types/genesis.pb.go # x/staking/types/query.pb.go # x/staking/types/staking.pb.go # x/staking/types/tx.pb.go # x/upgrade/types/upgrade.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #400
What is the purpose of the change
Manually brought changes from cosmos#13501, this could be used to better improve client tooling and proto annotations. Planning to get a PR for Osmosis code base as well once we have merged this
Brief Changelog
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)