Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement redacted fix #283

Merged
merged 1 commit into from
Jul 8, 2022
Merged

chore: implement redacted fix #283

merged 1 commit into from
Jul 8, 2022

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Jul 8, 2022

Description

Implements cosmos#12002 from upstream to our fork

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@czarcas7ic czarcas7ic marked this pull request as ready for review July 8, 2022 19:51
@czarcas7ic czarcas7ic requested a review from a team July 8, 2022 19:51
@czarcas7ic
Copy link
Member Author

Just pointing out that there is some non-determinism in the tests. Tests (00) failed, I reran and it passed.

@czarcas7ic czarcas7ic merged commit d49b3e7 into osmosis-main Jul 8, 2022
@czarcas7ic czarcas7ic deleted the adam/redacted-5 branch July 8, 2022 20:13
mergify bot pushed a commit that referenced this pull request Jul 8, 2022
(cherry picked from commit d49b3e7)
ValarDragon pushed a commit that referenced this pull request Jul 8, 2022
(cherry picked from commit d49b3e7)

Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants