Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Split ExportGenesis into two functions to maintain backwards compatibility #339

Merged

Conversation

nicolaslara
Copy link

This will allow us to use packages that depend on the old signature of ExportGenesis (like ibctesting).

@nicolaslara nicolaslara requested a review from a team October 4, 2022 11:09
@nicolaslara nicolaslara changed the title Split ExportGenesis into two functions to maintain backwards compatibility bug: Split ExportGenesis into two functions to maintain backwards compatibility Oct 4, 2022
@nicolaslara nicolaslara changed the title bug: Split ExportGenesis into two functions to maintain backwards compatibility chore: Split ExportGenesis into two functions to maintain backwards compatibility Oct 4, 2022
@nicolaslara
Copy link
Author

ps. my editor refuses to save without modifying the spacing on the comments. I can revert those manually if needed (though I don't think it matters, they're just comments)

@nicolaslara nicolaslara merged commit 2e4ae2f into osmosis-main Oct 4, 2022
@nicolaslara nicolaslara deleted the nicolas/backwards-compatible-export-genesis branch October 4, 2022 14:25
@julienrbrt
Copy link

julienrbrt commented Oct 4, 2022

We have upstreamed #336 in the SDK (cosmos#13437).
Please don't hesitate to upstream your changes directly :)
We have https://github.com/cosmos/cosmos-sdk/blob/main/.github/workflows/fork-cherry-pick.yml, to be configured in this repo, to facilitate that.

pysel pushed a commit to pysel/cosmos-sdk that referenced this pull request Dec 4, 2022
…rds compatibility (cosmos#13448)

* split ExportGenesis into two functions to maintain backwards compatibility (osmosis-labs#339)

* fix tests

Co-authored-by: Nicolas Lara <nicolaslara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants