Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add convenience method for constructing key to access account's balance for a given denom #352

Merged
merged 2 commits into from
Oct 13, 2022

Commits on Oct 13, 2022

  1. feat: Add convenience method for constructing key to access account's…

    … balance for a given denom (backport cosmos#12674) (cosmos#12745)
    
    * feat: Add convenience method for constructing key to access account's balance for a given denom (cosmos#12674)
    
    This PR adds a convenience method for constructing the key necessary to query for the account's balance of a given denom.
    
    I ran into this issue since we are using ABCI query now to perform balance requests because we are also requesting merkle proofs for the returned balance [here](https://github.com/celestiaorg/celestia-node/pull/911/files#diff-0ee31f5a7bd88e9f758e6bebdf3ee36365519e55a451098d9638c39afe5eac42R144).
    
    It would be nice to have a definitive convenience method for constructing the key.
    
    [Ref.](github.com/celestiaorg/celestia-node/pull/911)
    
    (cherry picked from commit a1777a8)
    
    * Update CHANGELOG.md
    
    * fix conflict
    
    Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
    Co-authored-by: Marko <marbar3778@yahoo.com>
    3 people authored and mattverse committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    a03bcf6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    985740e View commit details
    Browse the repository at this point in the history