Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch Int and Uint to cosmossdk.io/math #481

Merged
merged 1 commit into from
Aug 22, 2023
Merged

refactor: switch Int and Uint to cosmossdk.io/math #481

merged 1 commit into from
Aug 22, 2023

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 17, 2023 •
edited
Loading

Progress towards: osmosis-labs/osmosis#6099

What is the purpose of the change

Moving Int and Uint to sdkmath. The changes are based on: cosmos#11788

Brief Changelog

  • type alias Int and Uint to cosmossdk.io/math
  • Delete in-repo implementations
  • Replace instances of missing ToDec API with NewDecFromInt

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@p0mvn p0mvn marked this pull request as ready for review August 17, 2023 12:06
PaddyMc
PaddyMc approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@PaddyMc PaddyMc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@p0mvn p0mvn mentioned this pull request Aug 21, 2023
Merged
mattverse
mattverse approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all instances of sdk.Dec has been removed lgtm

types/coin.go Show resolved Hide resolved
types/decimal.go Show resolved Hide resolved
@p0mvn p0mvn merged commit 15e144a into osmosis-main Aug 22, 2023
@p0mvn p0mvn deleted the roman/sdkmath-int-uint branch August 22, 2023 16:02
@mergify mergify bot mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

@PaddyMc PaddyMc PaddyMc approved these changes

@nicolaslara nicolaslara Awaiting requested review from nicolaslara

@czarcas7ic czarcas7ic Awaiting requested review from czarcas7ic

Assignees
No one assigned
Labels
C:Simulations C:x/auth C:x/distribution C:x/gov C:x/slashing C:x/staking
Projects
Osmosis Chain Development
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @PaddyMc @mattverse