Remove 'blocked' IBC xfer Status #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 'blocked' status, and just left "congested", because users are confused about whether they can attempt IBC transfers
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jonator
reviewed
Nov 25, 2022
|
I think we should also prevent the button from turning red if a wallet is not connected. I noticed that in the preview. |
|
I can push a commit if you're up for it. For the higher threshold as well. |
|
Just merged. Please update this branch. We could still increase the number of minutes required to return each status. |
jonator
requested changes
Nov 30, 2022
jonator
approved these changes
Dec 3, 2022
JoseRFelix
pushed a commit
that referenced
this pull request
Dec 5, 2022
* Remove 'blocked' status
Remove 'blocked' status, and just left "congested", because users are confused about whether they can attempt IBC transfers
* update ibc types to delayed
* change blocked to congested
* update congested channel button message
* remove {coinDenom} from text
* readd blocked, but it won't display as 'blocked'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove 'blocked' status, and just left "congested", because users are confused about whether they can attempt IBC transfers.
Also changes congested timing to >20 mins of congestion, up from >5 mins.
Reason: There is currently an anomalous tx stuck in the Osmosis -> Cosmos Hub channel, which is making the transfer button say 'blocked'. This is confusing many users. The button for such an important function perhaps should have more consideration before telling users that it's blocked. It is not clear that they can still attempt to transfer, (and that it will most likely work, as many users report).
Was:
Proposed:
