(1CT) Enable other fee tokens for 1-Click Trading

[JoseRFelix]

Linear Task

https://linear.app/osmosis/issue/FE-1236/1ct-fix-insufficient-osmo-popping-up

Testing and Verifying

• Can do a 1CT tx even without having OSMO

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 26, 2024 2:37am

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
osmosis-frontend-datadog	⬜️ Ignored (Inspect)			Nov 26, 2024 2:37am
osmosis-frontend-dev	⬜️ Ignored (Inspect)			Nov 26, 2024 2:37am
osmosis-frontend-edgenet	⬜️ Ignored (Inspect)			Nov 26, 2024 2:37am
osmosis-testnet	⬜️ Ignored (Inspect)			Nov 26, 2024 2:37am

[coderabbitai]

Walkthrough

The changes in this pull request focus on the sendTradeTokenInTx function within the use-swap.tsx file. The modifications primarily enhance error handling for network fees and the one-click trading feature. Redundant checks have been removed, and user feedback through toast notifications has been improved with specific translations for different network fee errors. The overall structure of the function remains unchanged, but the comments have been updated for better clarity regarding the logic and conditions related to trading.

Changes

File	Change Summary
packages/web/hooks/use-swap.tsx	Modified sendTradeTokenInTx function to streamline error handling for network fees and one-click trading. Improved toast notifications for user feedback and updated comments for clarity.

Possibly related PRs

• 🤗 Embrace the 1-Click: Add 1-Click enable and modify to swap review #3954: The changes in this PR enhance the one-click trading feature, which is directly related to the modifications made in the sendTradeTokenInTx function in the main PR, as both involve improvements to trading functionalities and user interactions.
• 👻 Who Ya Gonna Call?: Fix referential instability in useSwap to stop continuous rerenders and high CPU usage #3956: This PR addresses performance issues in the useSwap hook, which is closely related to the changes in the sendTradeTokenInTx function in the main PR, as both involve error handling and optimizations in the trading process.

Suggested reviewers

• jonator
• CryptoAssassin1

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/web/hooks/use-swap.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/packages/web/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

packages/web/hooks/use-swap.tsx (1)

Line range hint 479-547: Improved error handling for one-click trading network fees.

The implementation properly handles network fee errors and provides clear user options. However, there are some potential improvements:

1. The error handling could be more granular to handle specific network fee error types.
2. The toast IDs could be more descriptive for better tracking.
3. The rejection error message could provide more context.

Consider these improvements:

-const TOAST_ID = networkFeeError
-  ? "ONE_CLICK_UNAVAILABLE"
-  : "ONE_CLICK_INSUFFICIENT_OSMO";
+const TOAST_ID = networkFeeError
+  ? "ONE_CLICK_NETWORK_FEE_ERROR"
+  : "ONE_CLICK_INSUFFICIENT_OSMO_BALANCE";

-return reject(new Error("Rejected manual approval"));
+return reject(new Error("User rejected manual approval for one-click trading transaction"));

// Consider adding specific network fee error type handling
+if (networkFeeError?.message.includes("insufficient_fee")) {
+  // Handle insufficient fee specifically
+} else if (networkFeeError?.message.includes("out_of_gas")) {
+  // Handle out of gas specifically
+}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 11449ab and e8d6a44.

📒 Files selected for processing (1)

• packages/web/hooks/use-swap.tsx (1 hunks)