(1CT) Split txs for Ledger in swap review modal #3972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
JoseRFelix
changed the title
jonator
approved these changes
Nov 26, 2024
JoseRFelix
deleted the
jose/fe-1253-handle-ledger-1ct-activation-from-swap-review
branch
JoseRFelix
added a commit
that referenced
this pull request
Nov 26, 2024
* feat: add events when creating 1CT session * (1CT) Split txs for Ledger in swap review modal (#3972) * feat: split txs for Ledger * fix: wrong override * feat: default to non ledger behavior * improvement: naming * improvement: typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change:
Due to the payload limit of Ledgers, it is sometimes impossible to initiate 1CT and perform a swap within the same transaction. As a result, we need to sign each tx individually when using a Ledger
Linear Task
https://linear.app/osmosis/issue/FE-1253/handle-ledger-1ct-activation-from-swap-review
Testing and Verifying