Use testnet historical data (Imperator) API on testnet #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ankurdotb
suggested changes
Oct 5, 2022
There was a problem hiding this comment.
I suggest sticking to declaring the base URL as a constant and even specifically not hardcoding it in the top-level file, so this can be injected as an environment variable. Perhaps set the default value as a value in constants file, and override it with value from environment if present?
daniel-farina
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: you should be able to see in the frontier/main preview, it has the correct historical data for mainnet. For testnet preview, it has testnet data (I think it's returning all 0 right now).