Add up all external incentive APYs for a specific duration #916
Conversation
|
@srph is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Actually- can we change it to find the incentives for a specific external gauge (given an ID), rather than adding them together for the given duration? Switch the API to accept a single gauge in place of the duration, and that also means you no longer need to pass in Our new design breaks down the APRs by gauge: Please call it Thanks |
|
@jonator Some updates:
All in all, I think it should've kept the first commit's behavior:
Let me know if there's anything I may have missed. Thanks! |
| const observableGauge = this.queryGauge.get(gaugeId); | ||
|
|
||
| if ( | ||
| duration.asMilliseconds() !== |
There was a problem hiding this comment.
I'm realizing that since we take in the gaugeId, there's no real reason to take in the duration as well and perform this check. Can we remove the duration from the params?
There was a problem hiding this comment.
@jonator Good catch, working on it =D
There was a problem hiding this comment.
Please make sure the comment/docs is updated as well.
There was a problem hiding this comment.
I think the main reason why we need duration is - on the pool page - we're simply iterating through the ExternalIncentiveGaugeAllowList[pool.id] (which would contain all gauges regardless of gauge)
Would you like me to move the duration checking there?
There was a problem hiding this comment.
Yeah we'd need to. I think we agree though it's a pointless constraint on anyone who wants to use this API to find the gauge's duration before being able to use the API.
|
Thanks for the review. Let me know if there's anything else I might have missed @jonator
|
In continuation of #886, this gets the sum of all external incentive APYs for the given duration rather than just calculating it from the first incentive.