Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IST #941

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Add IST #941

merged 2 commits into from
Oct 31, 2022

Conversation

zmanian
Copy link
Contributor

@zmanian zmanian commented Oct 30, 2022

No description provided.

@vercel
Copy link

vercel bot commented Oct 30, 2022

@zmanian is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

@zmanian zmanian mentioned this pull request Oct 30, 2022
Merged
JeremyParish69
JeremyParish69 requested changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@JeremyParish69 JeremyParish69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that we can put 'isVerified'.

Otherwise, it LGTM. The chain-infos data and img were already uploaded, so this should suffice. Price is still undefined, but that's OK for now.

@JeremyParish69 JeremyParish69 self-assigned this Oct 30, 2022
@zmanian
Copy link
Contributor Author

zmanian commented Oct 31, 2022

Why would BLD be verified and IST not be verified?

@jonator
Copy link
Member

jonator commented Oct 31, 2022

That's our way of marking incentivized/strategic assets to be included in the main app vs frontier.

@zmanian @sunnya97
Update packages/web/config/ibc-assets.ts
03aa9d8 
Co-authored-by: Sunny Aggarwal <sunnya97@gmail.com>
@zmanian
Copy link
Contributor Author

zmanian commented Oct 31, 2022

Changed

Are we good to merge?

the Decentralized Cooperation Foundation is planning incentivize the IST pools asap.

JeremyParish69
JeremyParish69 approved these changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@JeremyParish69 JeremyParish69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonator jonator merged commit ad79047 into osmosis-labs:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnya97 sunnya97 sunnya97 left review comments

@JeremyParish69 JeremyParish69 JeremyParish69 approved these changes

Assignees

@JeremyParish69 JeremyParish69

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zmanian @jonator @sunnya97 @JeremyParish69