Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ALTER, BUT, SHD, SIENNA & stkd-SCRT (Secret SNIP-20 tokens) #956

Merged
merged 19 commits into from
Nov 22, 2022
Merged

Add ALTER, BUT, SHD, SIENNA & stkd-SCRT (Secret SNIP-20 tokens) #956

merged 19 commits into from
Nov 22, 2022

Conversation

assafmo
Copy link
Contributor

@assafmo assafmo commented Nov 4, 2022

No description provided.

@vercel
Copy link

vercel bot commented Nov 4, 2022

@assafmo is attempting to deploy a commit to the OsmoLabs Team on Vercel.

A member of the Team first needs to authorize it.

@assafmo assafmo marked this pull request as draft November 4, 2022 08:34
@vercel
Copy link

vercel bot commented Nov 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
osmosis-frontier ✅ Ready (Inspect) Visit Preview Nov 22, 2022 at 7:11PM (UTC)

@assafmo assafmo changed the title Add ALTER, SHD & SIENNA (Secret SNIP-20 tokens) Add ALTER, BUT, SHD & SIENNA (Secret SNIP-20 tokens) Nov 4, 2022
@assafmo assafmo marked this pull request as ready for review November 4, 2022 17:51
@JeremyParish69 JeremyParish69 marked this pull request as draft November 8, 2022 00:52
@assafmo assafmo changed the title Add ALTER, BUT, SHD & SIENNA (Secret SNIP-20 tokens) Add ALTER, BUT, SHD, SIENNA & stkd-SCRT (Secret SNIP-20 tokens) Nov 9, 2022
@assafmo assafmo marked this pull request as ready for review November 9, 2022 14:42
@assafmo
Copy link
Contributor Author

assafmo commented Nov 9, 2022

Ready for review now.

@JeremyParish69 JeremyParish69 marked this pull request as draft November 10, 2022 21:05
@assafmo assafmo marked this pull request as ready for review November 12, 2022 05:41
@assafmo
Copy link
Contributor Author

assafmo commented Nov 15, 2022

What do we need to do to add these tokens to the main website too?

@mohammedpatla
Copy link

@JeremyParish69 Let us know what the next steps are and how can we get it on the main app as assafmo pointed out. ShadeProtocol is getting ready with a proposal for the pool on Osmosis as well, so any points that will push this forward is a plus.

@JeremyParish69
Copy link
Collaborator

What do we need to do to add these tokens to the main website too?

To get added to the main site goes by community governance, either if a pool containing the token gets Osmosis liquidity mining incentives or a simple text/"signalling" proposal to add to the main site.

@JeremyParish69 JeremyParish69 marked this pull request as draft November 17, 2022 20:47
@JeremyParish69 JeremyParish69 marked this pull request as ready for review November 22, 2022 19:32
JeremyParish69
JeremyParish69 approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@JeremyParish69 JeremyParish69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeremyParish69 JeremyParish69 merged commit 7d8fc3d into osmosis-labs:master Nov 22, 2022
@assafmo
Copy link
Contributor Author

assafmo commented Nov 23, 2022

Thanks @JeremyParish69!

@assafmo assafmo deleted the add-secret-snip20-tokens-to-frontier branch November 23, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnnyWyles JohnnyWyles JohnnyWyles left review comments

@mohammedpatla mohammedpatla mohammedpatla left review comments

@mradkov mradkov mradkov left review comments

@DrPresident DrPresident DrPresident left review comments

@JeremyParish69 JeremyParish69 JeremyParish69 approved these changes

Assignees

@JeremyParish69 JeremyParish69

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@assafmo @mohammedpatla @JeremyParish69 @DrPresident @mradkov @JohnnyWyles @jonator