Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auto/code-gen): improve upgrade handler code-gen to auto-run CI and apply labels #3628

Closed
p0mvn opened this issue Dec 5, 2022 · 2 comments
Closed

feat(auto/code-gen): improve upgrade handler code-gen to auto-run CI and apply labels #3628

p0mvn opened this issue Dec 5, 2022 · 2 comments
Assignees
@MasterPi-2124
Labels
T:auto Automatic items T:CI T:dev-UX

Comments

@p0mvn
Copy link
Member

p0mvn commented Dec 5, 2022

Background

There has been great progress toward code generating the upgrade handler via CI in:

Now, we can run the script that opens a PR like this:
#3627

There are some minor automation improvements possible.

Suggested Design

  1. Auto-apply our mandatory state-compatibility labels
  • It should be V:state/breaking
  1. Auto-run CI upon opening the code-generated pool request.

Acceptance Criteria

  • State-breakage label is auto-applied on PR creation
  • CI runs on PR creation w/o manual intervention
@p0mvn p0mvn added T:CI T:dev-UX T:auto Automatic items labels Dec 5, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Dec 5, 2022
@p0mvn p0mvn mentioned this issue Dec 5, 2022
Closed
MasterPi-2124 added a commit to MasterPi-2124/osmosis that referenced this issue Dec 20, 2022
@MasterPi-2124
osmosis-labs#3628
9ae6f6a
@MasterPi-2124
Copy link
Contributor

I created this pr on my fork and seem that it is working now: MasterPi-2124#12

This was referenced Jan 16, 2023
Merged
Closed
p0mvn pushed a commit that referenced this issue Jan 18, 2023
@phamminh0811 @MasterPi-2124
Remove dupplication in SwapAmountInRoute (#4039)
49dd541 
* #3628

* #3632

* macos sed syntax

* fix ci token

* debug

* add token

* update E2E_UPGRADE_VERSION version on Makefile as well

* Remove dupplication

* Update empty_upgrade_handler_gen.sh

* Fix proto

* remove route test

* revert branch

Co-authored-by: Master Pi <minh.vln140501@gmail.com>
p0mvn pushed a commit that referenced this issue Jan 18, 2023
@MasterPi-2124
Upgrade handler code-gen (#4031)
57d05f5 
* #3628

* #3632

* macos sed syntax

* fix ci token

* debug

* add token

* update E2E_UPGRADE_VERSION version on Makefile as well

* Update empty_upgrade_handler_gen.sh
@p0mvn
Copy link
Member Author

p0mvn commented Jan 25, 2023

Closed by: #4031

@p0mvn p0mvn closed this as completed Jan 25, 2023
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MasterPi-2124 MasterPi-2124

Labels
T:auto Automatic items T:CI T:dev-UX
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p0mvn @MasterPi-2124