Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/txfees: Make an ante-handler filter for recognizing Gamm arb txs, and charging a flat fee for them #723

Closed
ValarDragon opened this issue Jan 6, 2022 · 0 comments · Fixed by #741
Assignees
Labels
C:x/gamm Changes, features and bugs related to the gamm module. C:x/txfees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 6, 2022

To help combat arb bot fee spam, we should add a mempool filter detecting if a tx is an arb transaction. If so, require a different minimum fee than every other tx.

Theres three steps for this:

  • Make a gamm function for detecting if this multiMsg is an on-chain arb cycle
  • Make the anteHandler method use this for getting minimum gas price
  • Extend the app.toml config to expose this (instead of hardcoding something)

We can add new parameters to the app.toml config, e.g. see this PR: https://github.com/cosmos/cosmos-sdk/pull/10561/files

I don't yet know if its possible to add these from the Osmosis repo, or if we have to do it in the SDK fork.

@ValarDragon ValarDragon moved this from 🕒 Todo to 🏃 In Progress in Osmosis Chain Development Jan 9, 2022
@ValarDragon ValarDragon self-assigned this Jan 9, 2022
@ValarDragon ValarDragon added the C:x/gamm Changes, features and bugs related to the gamm module. label Jan 9, 2022
@ValarDragon ValarDragon moved this from 🏃 In Progress to 🔍 Needs Review in Osmosis Chain Development Jan 10, 2022
@ValarDragon ValarDragon moved this from 🔍 Needs Review to 🏃 In Progress in Osmosis Chain Development Jan 10, 2022
Repository owner moved this from 🏃 In Progress to ✅ Done in Osmosis Chain Development Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. C:x/txfees
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant