Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate app.toml code #737

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

tac0turtle
Copy link
Contributor

Closes: #XXX

Description

Copy & Paste

Screenshot 2022-01-07 at 13 30 19


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2022

Codecov Report

Merging #737 (4ae7217) into main (115c30e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #737   +/-   ##
=======================================
  Coverage   18.73%   18.73%           
=======================================
  Files         172      172           
  Lines       23908    23908           
=======================================
  Hits         4478     4478           
  Misses      18655    18655           
  Partials      775      775           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 115c30e...4ae7217. Read the comment docs.

@ValarDragon
Copy link
Member

ValarDragon commented Jan 7, 2022

oh cool! I was actually just trying to get to the bottom of whats going on in initAppConfig this week.

Looks like this is where we add more things to our app.toml, which we need to do for #723 , #724

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this works on a new node, ty!

@ValarDragon ValarDragon merged commit bc65a83 into osmosis-labs:main Jan 8, 2022
ValarDragon pushed a commit that referenced this pull request Jan 9, 2022
* remove duplicate code

* touchup

Co-authored-by: Marko Baricevic <markobaricevic3778@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants