smaller app.go #1009
Merged
smaller app.go #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1009 +/- ##
=======================================
Coverage 20.60% 20.60%
=======================================
Files 193 193
Lines 25237 25237
=======================================
Hits 5199 5199
Misses 19084 19084
Partials 954 954 Continue to review full report at Codecov.
|
ValarDragon
approved these changes
Mar 1, 2022
ValarDragon
reviewed
Mar 3, 2022
app/keys.go
Outdated
| txfeestypes "github.com/osmosis-labs/osmosis/v7/x/txfees/types" | ||
| ) | ||
|
|
||
| func KVStoreKeys() []string { |
There was a problem hiding this comment.
I think this belongs in keepers.go
ValarDragon
approved these changes
Mar 3, 2022
|
Ok I'll move the store keys to keepers.go and eliminate keys.go |
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
* create keys.go and blocked.go to make app.go easier * flatten NewOsmosisApp * Update app.go * fmt * eliminate keys.go and move store keys to keepers.go (cherry picked from commit 265890f)
ValarDragon
pushed a commit
that referenced
this pull request
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #671
Description
Today I worked on upgrading akash to v0.45.1 and got a feel for what @ValarDragon was describing for #671. I thought that moving the blocked addresses and store keys out would aid the cause.
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer