Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database stability improvements #1154

Merged
merged 4 commits into from
Mar 28, 2022
Merged

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Mar 26, 2022

Closes: #XXX

Description

  • upgraded iavl and SDK with the most recent database stability improvements
  • changelog updated

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #1154 (c0937aa) into v7.x (9b0420f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             v7.x    #1154   +/-   ##
=======================================
  Coverage   20.86%   20.86%           
=======================================
  Files         199      199           
  Lines       25416    25416           
=======================================
  Hits         5303     5303           
  Misses      19150    19150           
  Partials      963      963           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b0420f...c0937aa. Read the comment docs.

@p0mvn p0mvn marked this pull request as ready for review March 26, 2022 17:35
@p0mvn p0mvn requested a review from ValarDragon March 26, 2022 17:39
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is the changing the hardcoded constant from 780k to 100k in this branch as well? (I didn't see it on skim in IAVL / cosmos SDK changes)

I think we should publish a release once thats in

@p0mvn
Copy link
Member Author

p0mvn commented Mar 27, 2022

@ValarDragon I'm working on that today to represent the limit in terms of bytes and as a configurable value. Hoping to be done by EOD and merge in a separate PR.

If you'd like to get it out ASAP, I can hardcode it to 100K instead of the configurable bytes alternative I'm currently working on

@ValarDragon
Copy link
Member

Oh sweet, didn't realize your going for the limit in bytes at the moment, I thought that was something we'd do much later in the future. I think we should change it to 100k and get that into a release (the release can still come out tomorrow!)

I'm in favor of the limiting by bytes and a config value, but I don't think we should block the next release on that

@p0mvn
Copy link
Member Author

p0mvn commented Mar 27, 2022

Sounds good. I will prepare the PRs with 100K right now.

Will still keep working on the configurable value. If that doesn't get in before the next release, that's okay.

@ValarDragon
Copy link
Member

My main thinking as to why, is because we may get unforeseen troubles that would delay a release to mid-week with the change to bytes. (E.g. some unexpected edge case, takes longer to review on time, etc.)

I would rather get this out sooner, so we can get more information around the app hash situation, and mitigate the ongoing RAM usage concerns

@ValarDragon
Copy link
Member

Yeah, we can still make a release as soon as the config gets done / merged!

@p0mvn
Copy link
Member Author

p0mvn commented Mar 27, 2022

@ValarDragon updated sdk and iavl with smaller fast node cache size. Also, prepared changelog for v7.1.0 release

@ValarDragon ValarDragon merged commit 63633b8 into v7.x Mar 28, 2022
@ValarDragon ValarDragon deleted the roman/database-stability-updates branch March 28, 2022 15:16
@github-actions github-actions bot mentioned this pull request Feb 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants