test: switch e2e test setup to create genesis and configs via Dockertest #1363

czarcas7ic · 2022-04-27T23:34:07Z

Closes: #1332

What is the purpose of the change

This pull request utilizes the modularized e2e framework created by @p0mvn and makes it now possible to create a genesis and configuration based off a prior osmosis version. This is a required step in order to automate upgrade testing. Additionally, this PR was done in conjunction with @p0mvn.

Brief change log

Creation of ChainMeta and internalChain structs
Creation of export.go to assist in json unmarshalling
Using Dockertest, serialize data in a docker container and feed this data back into the e2e test framework
Retain config folder created by init docker image to be used as a volume in the upgrade docker container
Add build step for new docker image through make docker-build-e2e-chain-init

Testing and Verifying

This change is covered by the e2e test already implemented in this repository. This was also tested locally and continues to pass.

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? no
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
How is the feature or change documented? not documented

p0mvn

Awesome work on this @czarcas7ic ! Left some comments, please take a look

tests/e2e/e2e_setup_test.go

tests/e2e/chain/chain.go

tests/e2e/chain_init/main.go

tests/e2e/e2e_setup_test.go

Co-authored-by: Roman <roman@osmosis.team>

codecov-commenter · 2022-04-28T16:32:14Z

Codecov Report

Merging #1363 (36e4933) into main (66ebf33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1363   +/-   ##
=======================================
  Coverage   19.53%   19.53%           
=======================================
  Files         200      200           
  Lines       27532    27532           
=======================================
  Hits         5377     5377           
  Misses      21153    21153           
  Partials     1002     1002

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ebf33...36e4933. Read the comment docs.

p0mvn

LGTM

tests/e2e/e2e_setup_test.go

ValarDragon · 2022-04-28T18:19:23Z

tests/e2e/chain/config.go

 	// generate genesis txs
-	genTxs := make([]json.RawMessage, len(c.Validators))
-	for i, val := range c.Validators {
+	genTxs := make([]json.RawMessage, len(c.validators))
+	for i, val := range c.validators {


Not relevant to this PR, but I think we should extract this into a separate function, and add some more docs on whats going on with stakeAmountCoin, its non-obvious to me

Sure, I believe this is just adding the initial self-bond amount to each validator IIRC.

tests/e2e/chain/chain.go

alexanderbez

Excellent work @czarcas7ic

alexanderbez · 2022-04-28T18:42:12Z

tests/e2e/chain/config.go

 	// generate genesis txs
-	genTxs := make([]json.RawMessage, len(c.Validators))
-	for i, val := range c.Validators {
+	genTxs := make([]json.RawMessage, len(c.validators))
+	for i, val := range c.validators {


Sure, I believe this is just adding the initial self-bond amount to each validator IIRC.

alexanderbez · 2022-04-28T18:42:50Z

tests/e2e/chain/export.go

@@ -0,0 +1,25 @@
+package chain


Is there a doc.go on this package, export? What is it's purpose/intended use-case?

We marshal the data into a json within the docker container in order to later retrieve this data by the e2e test suite. When I initually tried to unmarshal this data however, I ran into an issue where the marshaler did not know how to handle some sdk structs that dont get exported. @p0mvn created this export package in order to export only the required structs needed to initialize the genesis and configs in order to get around this issue.

There is a README explaining what this package is for:
https://github.com/osmosis-labs/osmosis/blob/main/tests/e2e/README.md

@czarcas7ic could you check if README needs to be updated after this PR please

We can probably add to it by saying that the e2e test runner now does chain initialization in the container by default.

Other updates I noticed:

there is no upgrade package anymore, it was renamed earlier

state marshaling and unmarshaling on the volume

tests/e2e/chain_init/main.go

tests/e2e/e2e_setup_test.go

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

tests/e2e/e2e_setup_test.go

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

czarcas7ic and others added 6 commits April 27, 2022 16:11

commit for debug

3f2d278

refactor to only marshal basic types

bd2617f

external docker init with sleep

aafe7e3

add make docker-build-e2e-chain-init

837c8bd

change sleep for retry function

0e7411a

basic for loop in place of package

427efd3

czarcas7ic requested review from alexanderbez, ValarDragon and p0mvn April 27, 2022 23:34

github-actions bot added the Type:CI label Apr 27, 2022

update changelog

c566de6

czarcas7ic changed the title ~~test: switch e2e test setup to creating genesis and configs via Dockertest~~ test: switch e2e test setup to create genesis and configs via Dockertest Apr 27, 2022

p0mvn requested changes Apr 28, 2022

View reviewed changes

p0mvn reviewed Apr 28, 2022

View reviewed changes

tests/e2e/e2e_setup_test.go Outdated Show resolved Hide resolved

tests/e2e/e2e_setup_test.go Outdated Show resolved Hide resolved

czarcas7ic and others added 5 commits April 28, 2022 09:49

Update tests/e2e/e2e_setup_test.go

63968d3

Co-authored-by: Roman <roman@osmosis.team>

Update tests/e2e/e2e_setup_test.go

2e716fe

Co-authored-by: Roman <roman@osmosis.team>

Update tests/e2e/e2e_setup_test.go

3893791

Co-authored-by: Roman <roman@osmosis.team>

Update tests/e2e/chain_init/main.go

3c9f74e

Co-authored-by: Roman <roman@osmosis.team>

roman suggestions

84b2734

p0mvn approved these changes Apr 28, 2022

View reviewed changes

tests/e2e/e2e_setup_test.go Show resolved Hide resolved

add for loop purpose comment

790b97e

czarcas7ic mentioned this pull request Apr 28, 2022

test: move internalChain and internalValidator to internal package #1370

Closed

ValarDragon reviewed Apr 28, 2022

View reviewed changes

tests/e2e/chain/chain.go Show resolved Hide resolved

alexanderbez reviewed Apr 28, 2022

View reviewed changes

czarcas7ic and others added 3 commits April 28, 2022 14:17

Update tests/e2e/chain/chain.go

457b5a2

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

Update tests/e2e/e2e_setup_test.go

b32bea6

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>

group vars

36e4933

ValarDragon reviewed Apr 28, 2022

View reviewed changes

tests/e2e/e2e_setup_test.go Outdated Show resolved Hide resolved

czarcas7ic and others added 4 commits April 28, 2022 14:32

Merge branch 'main' into adam/chain-init

6ba1a6f

Update tests/e2e/e2e_setup_test.go

e78f5cd

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>

linter fix

9a276d3

fixed ineff assign err

7d0ca70

alexanderbez approved these changes Apr 28, 2022

View reviewed changes

czarcas7ic merged commit 8d28b8e into main Apr 28, 2022

czarcas7ic deleted the adam/chain-init branch April 28, 2022 21:56

github-actions bot mentioned this pull request Apr 1, 2024

Broken Links Detected #7903

Closed

github-actions bot mentioned this pull request Apr 15, 2024

Broken Links Detected #8046

Closed

github-actions bot mentioned this pull request Oct 15, 2024

Broken Links Detected notional-labs/osmosis#75

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: switch e2e test setup to create genesis and configs via Dockertest #1363

test: switch e2e test setup to create genesis and configs via Dockertest #1363

czarcas7ic commented Apr 27, 2022 •

edited

Loading

p0mvn left a comment

codecov-commenter commented Apr 28, 2022 •

edited

Loading

p0mvn left a comment

ValarDragon Apr 28, 2022

alexanderbez Apr 28, 2022

alexanderbez left a comment

alexanderbez Apr 28, 2022

alexanderbez Apr 28, 2022

czarcas7ic Apr 28, 2022 •

edited

Loading

p0mvn Apr 28, 2022

p0mvn Apr 28, 2022

test: switch e2e test setup to create genesis and configs via Dockertest #1363

test: switch e2e test setup to create genesis and configs via Dockertest #1363

Conversation

czarcas7ic commented Apr 27, 2022 • edited Loading

What is the purpose of the change

Brief change log

Testing and Verifying

Documentation and Release Note

p0mvn left a comment

Choose a reason for hiding this comment

codecov-commenter commented Apr 28, 2022 • edited Loading

Codecov Report

p0mvn left a comment

Choose a reason for hiding this comment

ValarDragon Apr 28, 2022

Choose a reason for hiding this comment

alexanderbez Apr 28, 2022

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

alexanderbez Apr 28, 2022

Choose a reason for hiding this comment

alexanderbez Apr 28, 2022

Choose a reason for hiding this comment

czarcas7ic Apr 28, 2022 • edited Loading

Choose a reason for hiding this comment

p0mvn Apr 28, 2022

Choose a reason for hiding this comment

p0mvn Apr 28, 2022

Choose a reason for hiding this comment

czarcas7ic commented Apr 27, 2022 •

edited

Loading

codecov-commenter commented Apr 28, 2022 •

edited

Loading

czarcas7ic Apr 28, 2022 •

edited

Loading