Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PoolAccount marshalling marshal weights as decimals #139

Merged
merged 12 commits into from
May 3, 2021
Merged

Make PoolAccount marshalling marshal weights as decimals #139

merged 12 commits into from
May 3, 2021

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented May 3, 2021 •
edited
Loading

This should be reviewed commit by commit. It moves marshalling code / tests to its own file

It makes only the YML serialization of a pool and PoolAsset return a truncation of the decimals, JSON serialization returns the exact value.

@sunnya97 sunnya97 merged commit 8639c4e into main May 3, 2021
@sunnya97 sunnya97 deleted the dev/make_weight_decimals branch May 3, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnya97 sunnya97 sunnya97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValarDragon @sunnya97