Add Hook for Extend Lockup Duration #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
May 5, 2022
x/lockup/types/hooks.go
Outdated
| @@ -12,6 +12,7 @@ type LockupHooks interface { | |||
| OnStartUnlock(ctx sdk.Context, address sdk.AccAddress, lockID uint64, amount sdk.Coins, lockDuration time.Duration, unlockTime time.Time) | |||
| OnTokenUnlocked(ctx sdk.Context, address sdk.AccAddress, lockID uint64, amount sdk.Coins, lockDuration time.Duration, unlockTime time.Time) | |||
| OnTokenSlashed(ctx sdk.Context, lockID uint64, amount sdk.Coins) | |||
| OnLockupExtend(ctx sdk.Context, address sdk.AccAddress, lockID uint64, amount sdk.Coins, prevDuration time.Duration, newDuration time.Duration, unlockTime time.Time) | |||
There was a problem hiding this comment.
Should the API be ctx, lockID, oldDuration ?
There was a problem hiding this comment.
I just put all the fields on the method, if that is sufficient I think it is good(although maybe adding newDuration?)
ValarDragon
approved these changes
May 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
- Coverage 19.82% 19.53% -0.29%
==========================================
Files 202 226 +24
Lines 27685 30953 +3268
==========================================
+ Hits 5489 6048 +559
- Misses 21175 23800 +2625
- Partials 1021 1105 +84
Continue to review full report at Codecov.
|
alexanderbez
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1404
What is the purpose of the change
*Add a description of the overall background and high level changes that this PR introduces *
(E.g.: This pull request improves documation of area A by adding ....
Brief change log
(for example:)
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)