v8 Major release checklist: Updated Changelog.md #1515
Conversation
stackman27
changed the title
CHANGELOG.md
Outdated
| * [#1481] Emergency upgrade as of prop [226] (https://www.mintscan.io/osmosis/proposals/226) | ||
| * [#1435] `x/tokenfactory` create denom fee for spam resistance | ||
| * [#1429] solver for multi-asset CFMM | ||
| * [#1253] Add lockup duration edit method |
There was a problem hiding this comment.
Please make the numbers link to the PRs similar to earlier releases
There was a problem hiding this comment.
We actually made a script for this at some point in the SDK, just it never fit in the natural dev flow. I wonder if theres a good way to fit it back in
CHANGELOG.md
Outdated
| ### Minor improvements & Bug Fixes | ||
| * [#1233] Move messageServer logic for LockTokens into keeper method | ||
| * [#1440] fix(proto/tokenfactory): fix annotation | ||
| * [#1307] refactor: JoinSwapShareAmountOut |
There was a problem hiding this comment.
Many other PRs I see here did not go into v8
There was a problem hiding this comment.
is there a list of PRs that goes into v8? i was mostly going off of new merges here
There was a problem hiding this comment.
If you 'git checkout v8.0.0', you will be on that release's tag. Then, 'git log' would give you the commit history.
Also, our branch for v8 releases is called v8.x. You can switch to it on GitHub to check out the history as well
There was a problem hiding this comment.
Gotchu. Thank you!
|
Thank you so much for making this! Can you just take all the changes in the changelog, aside from and move those to the unreleased section above v8.0.0? (Sorry its pretty confusing! But that in large part is why we need the changelog update) |
Codecov Report
@@ Coverage Diff @@
## main #1515 +/- ##
=======================================
Coverage 19.57% 19.57%
=======================================
Files 236 236
Lines 31639 31639
=======================================
Hits 6194 6194
Misses 24310 24310
Partials 1135 1135 Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
| * [#840] Move lock.go functions into iterator.go, lock_refs.go and store.go | ||
| * [#916] And a fn for Unbond and Burn tokens | ||
| * [#908] Superfluid slashing code | ||
| * [#904] LockAndSuperfluidDelegate |
There was a problem hiding this comment.
All of the features except * [#1262](https://github.com/osmosis-labs/osmosis/pull/1262) Add a forceprune command to the binaries, that prunes golevelDB data better., and minor improvements should go above. Then this looks good to merge to me!
There was a problem hiding this comment.
Moved * [#1262](https://github.com/osmosis-labs/osmosis/pull/1262) Add a forceprune command to the binaries, that prunes golevelDB data better. and minor improvements under features!
stackman27
force-pushed
the
changelog-v8-updates
branch
from
05a29a6 to
ec4fcd8
Compare
|
Sorry about that @ValarDragon. I got a little confused. Is there a way to check which PRs are bug fixes vs improvements without going through them individually? |
|
Not realy, but the PR LGTM right now! |
Closes: #1494 [changelog]
What is the purpose of the change
Changelog.md. Doing this for the first time, so i might've missed some PRs 😅. Happy to update as per requestBrief Changelog
Testing and Verifying
n/a
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)