e2e: chain initialization refactor for extensibility #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:docs
p0mvn
commented
Jun 29, 2022
czarcas7ic
approved these changes
Jun 30, 2022
| # Docker ARGs are not expanded in ENTRYPOINT in the exec mode. At the same time, | ||
| # it is impossible to add CMD arguments when running a container in the shell mode. | ||
| # As a workaround, we create the entrypoint.sh script to bypass these issues. | ||
| RUN echo "#!/bin/bash\n${E2E_SCRIPT_NAME} \"\$@\"" >> entrypoint.sh && chmod +x entrypoint.sh |
There was a problem hiding this comment.
For my learning, what are the semantics here \"\$@\""? I have never seen this before.
There was a problem hiding this comment.
This is bash syntax for expanding cmd line parameters.
Basically, since we want to call chain init and node init scripts by providing them with certain initialization arguments via Docker, we need to be able to expand them in the bash script.
This post points to a relevant man page about the syntax:
https://stackoverflow.com/questions/3898665/what-is-in-bash
ValarDragon
approved these changes
Jun 30, 2022
Co-authored-by: Adam Tucker <adam@osmosis.team>
|
Thanks for the reviews, all comments are addressed so I'm going to merge this. |
This was referenced Jun 30, 2022
p0mvn
added a commit
that referenced
this pull request
Jun 30, 2022
This was referenced Jun 30, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #1879
What is the purpose of the change
Our current chain initialization design does not allow for spinning up single nodes. This functionality is useful for testing feautes like state-sync.
This PR introduced the barebones structure to initialize single nodes via Docker. To build a single node initialization image, run:
Additional information about the new design can be found in
tests/e2e/initialization/README.mdBrief Changelog
initialzationpackageARGTesting and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no