x/lock: Fix ExtendLockup API
#1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
approved these changes
Jul 1, 2022
ValarDragon
reviewed
Jul 1, 2022
ValarDragon
reviewed
Jul 1, 2022
ValarDragon
approved these changes
Jul 1, 2022
p0mvn
approved these changes
Jul 1, 2022
|
thanks for adding the chnage log and merging! |
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2022
* Fix extendlock api * Apply suggestions from code review * Add changelog Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu> (cherry picked from commit 99304f2) # Conflicts: # CHANGELOG.md
mattverse
added a commit
that referenced
this pull request
Jul 12, 2022
* x/lock: Fix `ExtendLockup` API (#1937) * Fix extendlock api * Apply suggestions from code review * Add changelog Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu> (cherry picked from commit 99304f2) # Conflicts: # CHANGELOG.md * Fix merge conflict: changelog Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: mattverse <mattpark1028@gmail.com>
ValarDragon
added a commit
that referenced
this pull request
Aug 1, 2022
This reverts commit bd32316.
ValarDragon
added a commit
that referenced
this pull request
Aug 3, 2022
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub-component of: #1838
What is the purpose of the change
The current
ExtendLockupAPI directly takes in the lock object as a pointer as its parameter. This PR changes this existing API to take in lock ID to improve safety for this APIBrief Changelog
Improve
ExtendLockupAPI safety.Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no