Fix Initgenesis bug in tokenfactory, when the denom creation fee para… #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
commented
Jul 10, 2022
Comment on lines
-20
to
-30
| // Send creation fee to community pool | ||
| creationFee := k.GetParams(ctx).DenomCreationFee | ||
| accAddr, err := sdk.AccAddressFromBech32(creatorAddr) | ||
| err = k.chargeForCreateDenom(ctx, creatorAddr, subdenom) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| if len(creationFee) > 0 { | ||
| if err := k.distrKeeper.FundCommunityPool(ctx, creationFee, accAddr); err != nil { | ||
| return "", err | ||
| } | ||
| } |
There was a problem hiding this comment.
Moved to chargeForCreateDenom
alexanderbez
approved these changes
Jul 10, 2022
czarcas7ic
approved these changes
Jul 10, 2022
ValarDragon
added
A:backport/v10.x
mergify bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
#2011) * Fix Initgenesis bug in tokenfactory, when the denom creation fee param is set * Add more to genesis test that would've caught this * Update changelog * Fix remaining bug adam pointed out * Make test account for this * Update code comment (cherry picked from commit 938f9bd) # Conflicts: # CHANGELOG.md # x/tokenfactory/keeper/createdenom.go # x/tokenfactory/keeper/createdenom_test.go # x/tokenfactory/keeper/genesis_test.go
ValarDragon
added a commit
that referenced
this pull request
Jul 11, 2022
…… (backport #2011) (#2020) * Fix Initgenesis bug in tokenfactory, when the denom creation fee para… (#2011) * Fix Initgenesis bug in tokenfactory, when the denom creation fee param is set * Add more to genesis test that would've caught this * Update changelog * Fix remaining bug adam pointed out * Make test account for this * Update code comment (cherry picked from commit 938f9bd) # Conflicts: # CHANGELOG.md # x/tokenfactory/keeper/createdenom.go # x/tokenfactory/keeper/createdenom_test.go # x/tokenfactory/keeper/genesis_test.go * Progress on merge conflicts * Fix changelog bug * Remove unused import Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…m is set
What is the purpose of the change
Fixes a bug Adam pointed out, in TokenFactory genesis handling. (Which led to panics in his testnet generation)
Brief Changelog
Testing and Verifying
This change added tests and can be verified as follows:
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yes