gamm keeper delete obsolete files #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlpinYukseloglu
added
the
C:x/gamm
mattverse
approved these changes
Jul 20, 2022
ValarDragon
approved these changes
Jul 20, 2022
| @@ -21,6 +21,6 @@ option go_package = "github.com/osmosis-labs/osmosis/v10/x/gamm/types"; | |||
| message GenesisState { | |||
| repeated google.protobuf.Any pools = 1 | |||
| [ (cosmos_proto.accepts_interface) = "PoolI" ]; | |||
| uint64 next_pool_number = 2; | |||
| uint64 next_pool_id = 2; | |||
There was a problem hiding this comment.
AFAIU, when you break proto like this, you technically have to bump the package version. i.e. osmosis.gamm.v2beta1;
There was a problem hiding this comment.
So field name changes like this break clients and json serialization, but I think its fine to do so for genesis
cc @daniel-farina @czarcas7ic if field renames / genesis file breaks like this end up being problematic for integrators
|
Can we separate out the deletes here from the genesis field rename Can easily get all the file deletes merged |
|
Actually I'll just commit undoing that proto field rename, and we can re-open a new issue for talking about genesis breaks |
mergify bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
* remove vestigial test files * move params into keeper.go * move stableswap scaling factor * change pool number to pool id where applicable * further pool number changes * make proto level pool number changes * add changelog entry * remove completed TODO comment * undo proto change Co-authored-by: Dev Ojha <dojha@berkeley.edu> (cherry picked from commit 8cac090) # Conflicts: # CHANGELOG.md # go.mod # x/gamm/keeper/genesis.go # x/gamm/keeper/grpc_query.go # x/gamm/keeper/params.go # x/gamm/keeper/pool.go # x/gamm/keeper/pool_service.go # x/gamm/pool-models/stableswap/pool.go # x/gamm/simulation/sim_msgs.go
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2155
What is the purpose of the change
Cleanup of
x/gamm/keeperBrief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)