Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: minor pass through twap imrovements #2284

Merged
merged 6 commits into from
Aug 3, 2022
Merged

refactor: minor pass through twap imrovements #2284

merged 6 commits into from
Aug 3, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Aug 3, 2022

Closes: #XXX

What is the purpose of the change

Some minor pass through changes discovered while reviewing #2168

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label Aug 3, 2022
p0mvn
p0mvn commented Aug 3, 2022
View reviewed changes
x/gamm/twap/store.go Outdated Show resolved Hide resolved
@p0mvn p0mvn marked this pull request as ready for review August 3, 2022 00:10
@p0mvn p0mvn requested a review from a team August 3, 2022 00:10
p0mvn
p0mvn commented Aug 3, 2022
View reviewed changes
x/gamm/twap/store.go Outdated Show resolved Hide resolved
p0mvn
p0mvn commented Aug 3, 2022
View reviewed changes
x/gamm/twap/store.go Outdated Show resolved Hide resolved
p0mvn and others added 2 commits August 2, 2022 20:14
@p0mvn
Update x/gamm/twap/store.go
fcedd02
@p0mvn @ValarDragon
Update x/gamm/twap/store.go
b706cab 
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
alexanderbez
alexanderbez approved these changes Aug 3, 2022
View reviewed changes
x/gamm/twap/keeper.go Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 4d50629 into main Aug 3, 2022
@mergify mergify bot deleted the roman/twap-improve branch August 3, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees
No one assigned
Labels
A:automerge C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p0mvn @alexanderbez @ValarDragon