Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move osmoutils into its own go mod #3827

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Conversation

ValarDragon
Copy link
Member

What is the purpose of the change

Completes the move of osmoutils into its own go.mod

Brief Changelog

  • change import paths
  • add go.mod into osmoutils package
  • update root go.mod and go.work

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? N/A

@github-actions github-actions bot added C:app-wiring Changes to the app folder C:CLI C:simulator Edits simulator or simulations C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/lockup C:x/mint C:x/pool-incentives C:x/superfluid C:x/swaprouter C:x/tokenfactory C:x/twap Changes to the twap module C:x/txfees labels Dec 22, 2022
@ValarDragon ValarDragon added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v13.x backport patches to v13.x branch labels Dec 22, 2022
Copy link
Contributor

@nicolaslara nicolaslara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicolaslara
Copy link
Contributor

Linking this pre-requisite here for future reference: #3817

@ValarDragon ValarDragon merged commit 93181a4 into main Dec 22, 2022
@ValarDragon ValarDragon deleted the dev/osmoutils_own_go_mod branch December 22, 2022 14:35
mergify bot pushed a commit that referenced this pull request Dec 22, 2022
* Move osmoutils into its own go mod

* go mod tidy

* Add changelog

(cherry picked from commit 93181a4)

# Conflicts:
#	app/modules.go
#	go.work.sum
#	tests/ibc-hooks/ibc_middleware_test.go
#	x/downtime-detector/client/cli/query.go
#	x/downtime-detector/client/cli/query_test.go
#	x/downtime-detector/store.go
#	x/ibc-hooks/genesis.go
#	x/ibc-hooks/wasm_hook.go
#	x/swaprouter/client/cli/cli_test.go
#	x/swaprouter/create_pool.go
#	x/swaprouter/keeper.go
#	x/twap/logic_test.go
#	x/twap/strategy_test.go
#	x/valset-pref/client/cli/query.go
#	x/valset-pref/client/cli/tx.go
#	x/valset-pref/keeper.go
#	x/valset-pref/types/msgs.go
ValarDragon added a commit that referenced this pull request Dec 23, 2022
* Move osmoutils into its own go mod (#3827)

* Move osmoutils into its own go mod

* go mod tidy

* Add changelog

(cherry picked from commit 93181a4)

# Conflicts:
#	app/modules.go
#	go.work.sum
#	tests/ibc-hooks/ibc_middleware_test.go
#	x/downtime-detector/client/cli/query.go
#	x/downtime-detector/client/cli/query_test.go
#	x/downtime-detector/store.go
#	x/ibc-hooks/genesis.go
#	x/ibc-hooks/wasm_hook.go
#	x/swaprouter/client/cli/cli_test.go
#	x/swaprouter/create_pool.go
#	x/swaprouter/keeper.go
#	x/twap/logic_test.go
#	x/twap/strategy_test.go
#	x/valset-pref/client/cli/query.go
#	x/valset-pref/client/cli/tx.go
#	x/valset-pref/keeper.go
#	x/valset-pref/types/msgs.go

* tryfix conflicts

Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Dev Ojha <dojha@berkeley.edu>
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v13.x backport patches to v13.x branch C:app-wiring Changes to the app folder C:CLI C:simulator Edits simulator or simulations C:x/epochs C:x/gamm Changes, features and bugs related to the gamm module. C:x/incentives C:x/lockup C:x/mint C:x/pool-incentives C:x/superfluid C:x/swaprouter C:x/tokenfactory C:x/twap Changes to the twap module C:x/txfees V:state/compatible/backport State machine compatible PR, should be backported
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants