Allow whitelisted tx fee tokens based on conversion rate to OSMO #394
Conversation
| func GetCmdDenomPoolID() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "denom-pool-id", | ||
| Short: "Query the pool id associated with a specific whitelisted fee token", |
There was a problem hiding this comment.
If ATOM is whitelisted for ATOM/OSMO and ATOM/AKT pair, what does this return?
There was a problem hiding this comment.
It will check that only one pool can be whitelisted per denom. It also should make sure that selected pool does contain the native fee token (OSMO)
|
Going to take over this PR in a new branch, for an MVP of just the state changes & ensuring only allowed fee tokens are put on change. This would then enable tx fees in CheckTx to be written in a second PR |
sunnya97
force-pushed
the
sunny/autoswap-fees
branch
from
b6a5f4c
to
e4ae67c
Compare
|
Should merge osmosis-labs/cosmos-sdk#42 first |
|
Thanks @antstalepresh for the great review! |
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
|
PR looks good for me, testing the module with CLI command and adding README would be helpful. |
x/txfees/module.go
Outdated
| func (AppModuleBasic) RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) { | ||
| types.RegisterCodec(cdc) | ||
| } |
There was a problem hiding this comment.
Not used in https://github.com/cosmos/cosmos-sdk/blob/master/x/authz/module/module.go#L50, which I believe has ledger support.
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 20.31% 20.72% +0.40%
==========================================
Files 164 172 +8
Lines 23262 23465 +203
==========================================
+ Hits 4726 4863 +137
- Misses 17762 17812 +50
- Partials 774 790 +16 ☔ View full report in Codecov by Sentry. |
closes #404