fix(twap/e2e): set geometric accum to zero; reproduce testnet bug #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/breaking
ValarDragon
approved these changes
Jan 10, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
) * fix(twap/e2e): set geometric accum to zero; reproduce testnet bug * test TestParseTwapFromBz * clean up (cherry picked from commit a693a3b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
No migration alternative to: #3970
In #3542, it was concluded that we do not need to perform the migrations to initialize the geometric twap accumulator.
However, the testnet halted due to the geometric twap accumulator ending up uninitialized.
The reason why our e2e test did not catch this problem was because we never swapped against a pool that was created pre-upgrade after the upgrade itself.
This PR reproduced the testnet halt bug and fixed it by forcing to set the geometric twap accumulator to zero after it is parsed.
Brief Changelog
Testing and Verifying
This change added e2e and
ParseRecordFromBztests.Brief Changelog
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no