Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster CI for contracts #4061

Closed
wants to merge 4 commits into from
Closed

Faster CI for contracts #4061

wants to merge 4 commits into from

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

Make it easier to compile the x86 contracts on CI

Brief Changelog

  • Only running the optimizer once

Testing and Verifying

CI should pass

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (/ no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (/ no)
  • How is the feature or change documented? (not applicable )

@github-actions github-actions bot added the T:CI label Jan 18, 2023
@nicolaslara nicolaslara added the V:state/compatible/backport State machine compatible PR, should be backported label Jan 18, 2023
@ValarDragon
Copy link
Member

can we add some comments to this, I don't really understand it tbh, I imagine next editor will have similar problems

@nicolaslara
Copy link
Contributor Author

sorry, yeah, this is not done. I'll make it a draft

@nicolaslara nicolaslara marked this pull request as draft January 18, 2023 14:00
@nicolaslara
Copy link
Contributor Author

My objective here is to execute the optimize and upload artifacts steps only once per workdir, but then check all the diffs.

My initial experiments are not working, so I'll move on and come back to this later

@nicolaslara
Copy link
Contributor Author

I'm gonna close this for now. Need to revisit this eventually. Added an issue to track it: #4123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:CI V:state/compatible/backport State machine compatible PR, should be backported
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants