Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding to a finished gauge (backport #4306) #4308

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 14, 2023

This is an automatic backport of pull request #4306 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Prevent adding to a finished gauge

* Add changelog

* Fix simulation

* Remove unneeded line

(cherry picked from commit cc90c10)
@github-actions github-actions bot added C:simulator Edits simulator or simulations C:x/incentives labels Feb 14, 2023
@ValarDragon
Copy link
Member

cc @p0mvn for whether you think this should be v15 or not

@ValarDragon
Copy link
Member

ValarDragon commented Feb 16, 2023

Seeing as no reply + timeline creep, going to close this as not in scope for v15.

@mergify mergify bot deleted the mergify/bp/v15.x/pr-4306 branch February 16, 2023 06:23
@p0mvn
Copy link
Member

p0mvn commented Feb 16, 2023

Seeing as no reply + timeline creep, going to close this as not in scope for v15.

Apologies missed the notification. I agree on the decision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:simulator Edits simulator or simulations C:x/incentives
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants