Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statesync #444

Merged
merged 22 commits into from
Oct 7, 2021
Merged

Statesync #444

merged 22 commits into from
Oct 7, 2021

Conversation

faddat
Copy link
Member

@faddat faddat commented Aug 24, 2021

Adds a script and a test for state sync.

This is currently failing, but in the future will give us a known-good state sync configuration.

Request help with a fix, I am a bit puzzled.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #444 (59dbb09) into main (3d74adf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #444   +/-   ##
=======================================
  Coverage   19.88%   19.88%           
=======================================
  Files         153      153           
  Lines       23040    23040           
=======================================
  Hits         4581     4581           
  Misses      17707    17707           
  Partials      752      752           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d74adf...59dbb09. Read the comment docs.


# MAKE HOME FOLDER AND GET GENESIS
osmosisd init test
wget -O ~/.osmosisd/config/genesis.json https://cloudflare-ipfs.com/ipfs/QmXRvBT3hgoXwwPqbK6a2sXUuArGM8wPyo1ybskyyUwUxs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this trying to state sync against mainnet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way that I'm looking at this is we can use this as an indicator of changes that would cause differences in the app hash, and of changes that might break state sync itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will currently fail in the master branch but we can tag it with that one setting that causes it to continue on error.

@faddat
Copy link
Member Author

faddat commented Sep 3, 2021

This now runs in 4 minutes and 17 seconds.

If we do a v3.10.1, And put tendermint 34.12 In it, that will allow people to smoothly state sync using this script.

Just like the peers in the init file, this will need more participation from the validator community to ensure that it is nice and decentralized but for now I can run a bootstrap node that's no problem.

@ValarDragon
Copy link
Member

Awesome, glad that this is landing!

I don't super understand how we envision this test getting ran, should we have it be like a daily build against a branch?

main collects breaking changes for the next versions state machine

@ValarDragon
Copy link
Member

ValarDragon commented Sep 4, 2021

I'm happy to make the CI part workflow_dispatch only, get a daily build going there, and merge this script in.

We should start maintaining v3.x and v4.x branches, and then perhaps have this state sync script be running against though?

I've done the Tendermint change you need in the v3.2.0 branch, which has accumulated a bunch of the minor improvemetns from main and epoch speedups.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we change this. I think its good to merge

.github/workflows/statesync.yml Outdated Show resolved Hide resolved
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ValarDragon ValarDragon merged commit 17eda92 into osmosis-labs:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants