Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unlocking lock id to BeginUnlocking response #4489

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Add unlocking lock id to BeginUnlocking response #4489

merged 2 commits into from
Mar 3, 2023

Conversation

nicolaslara
Copy link
Contributor

What is the purpose of the change

When a contract submits a partial unlock request, a new lock is created. At the moment there is no way to obtain the created lock id. This PR changes that

Brief Changelog

  • Add a unlockingLockID field to MsgBeginUnlockingResponse
  • Modified unlocking functions to return the lock

Testing and Verifying

Tests have been modified to check the lock id on partial unlocks

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes )
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes /)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@nicolaslara nicolaslara added the V:state/breaking State machine breaking PR label Mar 3, 2023
@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v15.x backport patches to v15.x branch and removed V:state/compatible/backport State machine compatible PR, should be backported labels Mar 3, 2023
ValarDragon
ValarDragon approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified that beginUnlock returns lockId under the same semantic as here

@ValarDragon ValarDragon merged commit d5f8210 into main Mar 3, 2023
@ValarDragon ValarDragon deleted the nicolas/partial-locks-return-new-lock-id branch March 3, 2023 18:37
@mergify mergify bot mentioned this pull request Mar 3, 2023
Merged
mergify bot pushed a commit that referenced this pull request Mar 3, 2023
@nicolaslara @mergify
Add unlocking lock id to BeginUnlocking response (#4489)
eed396f 
* added unlocking lock id

* added changelog

(cherry picked from commit d5f8210)

# Conflicts:
#	x/superfluid/keeper/migrate_test.go
p0mvn added a commit that referenced this pull request Mar 3, 2023
@p0mvn
Add unlocking lock id to BeginUnlocking response (backport #4489)
9d934be
p0mvn added a commit that referenced this pull request Mar 3, 2023
@mergify @p0mvn
Add unlocking lock id to BeginUnlocking response (backport #4489) (#4495
3ffb10f 
)

Co-authored-by: Roman <roman@osmosis.team>
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

@ValarDragon ValarDragon ValarDragon approved these changes

@mattverse mattverse Awaiting requested review from mattverse mattverse is a code owner

Assignees
No one assigned
Labels
A:backport/v15.x backport patches to v15.x branch C:x/lockup C:x/superfluid V:state/breaking State machine breaking PR
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolaslara @ValarDragon @p0mvn