ProtoRev: Adding Txs to CLI

[davidterpay]

What is the purpose of the change

In this PR, I add the remaining admin transactions to the CLI. Additionally, I add one modification to MsgSetMaxPoolPointsPer(Tx/Block) so that the max pool points per tx cannot be set to something higher than the max pool points per block and vice versa.

Brief Changelog

• Added all protorev txs to the cli
• Added an additional check to SetMaxPoolPointsPerTx and SetMaxPoolPointsPerBlock
• Update the protorev spec

Testing and Verifying

This change is already covered by existing tests. Additionally, I tested all of the CLI commands locally with accounts that were designated as the admin account and those that were not, with various params (correct and incorrect), and more. The CLI commands function as expected.

Documentation and Release Note

Updated the x/protorev spec to include all of the updates made in this PR.

[davidterpay]

To reviewers: I'm not super familiar with osmocli so I'm not sure if there is a more optimal way of reading in the json file and building the TokenPairArbRoutes since the only thing that is problematic is dealing with the StepSize which is an sdk.Int.

[p0mvn]

The only other example I know of parsing a file withing our cli is the pool file:

osmosis/x/gamm/client/cli/parse.go

Lines 27 to 39 in 3cd13a6

	// UnmarshalJSON should error if there are fields unexpected.
	func (release *createBalancerPoolInputs) UnmarshalJSON(data []byte) error {
	var createPoolE XCreatePoolInputsExceptions
	dec := json.NewDecoder(bytes.NewReader(data))
	dec.DisallowUnknownFields() // Force
	if err := dec.Decode(&createPoolE); err != nil {
	return err
	}
	*release = createBalancerPoolInputs(createPoolE.XCreatePoolInputs)
	return nil
	}

This implementation seems to be aligned with that. If parsing files becomes a common theme, we can better abstract it in the future

[p0mvn]

utACK

Thanks for this change and for testing it out locally

[p0mvn]

Non-blocking but just FYI for future contributions that it is beneficial to separate state-breaking changes from non-state-breaking so that we can release non-state-breaks sooner.

We have docs for this here:

osmosis/CONTRIBUTING.md

Line 365 in d945e62

### State-compatibility

If we only had CLI changes in this PR, we could release them in the v15 line. Since there are message server changes, this will have to wait till v16.

[davidterpay]

Got it. Will keep that in mind once we start working on the metrics/events update.

[p0mvn]

The only other example I know of parsing a file withing our cli is the pool file:

osmosis/x/gamm/client/cli/parse.go

Lines 27 to 39 in 3cd13a6

	// UnmarshalJSON should error if there are fields unexpected.
	func (release *createBalancerPoolInputs) UnmarshalJSON(data []byte) error {
	var createPoolE XCreatePoolInputsExceptions
	dec := json.NewDecoder(bytes.NewReader(data))
	dec.DisallowUnknownFields() // Force
	if err := dec.Decode(&createPoolE); err != nil {
	return err
	}
	*release = createBalancerPoolInputs(createPoolE.XCreatePoolInputs)
	return nil
	}

This implementation seems to be aligned with that. If parsing files becomes a common theme, we can better abstract it in the future