Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only do one massive send for all gauge distribution #510

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

ValarDragon
Copy link
Member

@ValarDragon ValarDragon commented Oct 7, 2021

Changes the distribution logic to only do one bank multi-send for all the gauges, which should significantly help in speed / reducing the number of events. This may be state compatible with mainnet. This needs to be tested.

This needs to update the tests, and add a changelog entry.

@ValarDragon ValarDragon marked this pull request as ready for review October 10, 2021 05:34
@codecov-commenter
Copy link

Codecov Report

Merging #510 (5a39498) into main (17eda92) will increase coverage by 0.02%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   20.41%   20.44%   +0.02%     
==========================================
  Files         163      163              
  Lines       23206    23185      -21     
==========================================
+ Hits         4738     4740       +2     
+ Misses      17694    17668      -26     
- Partials      774      777       +3     
Impacted Files Coverage Δ
x/incentives/types/hooks.go 0.00% <0.00%> (ø)
x/incentives/keeper/hooks.go 43.75% <33.33%> (+6.25%) ⬆️
x/incentives/keeper/gauge.go 68.06% <71.42%> (+6.73%) ⬆️
x/claim/genesis.go 60.00% <0.00%> (-9.24%) ⬇️
x/pool-incentives/types/genesis.go 32.00% <0.00%> (-2.79%) ⬇️
x/pool-incentives/keeper/distr.go 82.82% <0.00%> (-1.14%) ⬇️
x/claim/keeper/claim.go 64.16% <0.00%> (-1.09%) ⬇️
x/incentives/keeper/store.go 76.74% <0.00%> (-0.53%) ⬇️
app/app.go 85.47% <0.00%> (ø)
x/mint/keeper/keeper.go 63.63% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17eda92...5a39498. Read the comment docs.

Copy link
Member

@UnityChaos UnityChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM

Seems like a pretty straightforward improvement 👍

@ValarDragon
Copy link
Member Author

Awesome, ty! Will merge and test if its also mainnet compatible.

@ValarDragon ValarDragon merged commit f1929ea into main Oct 11, 2021
@ValarDragon ValarDragon deleted the dev/fewer_liquidity_events branch October 11, 2021 23:24
ValarDragon added a commit that referenced this pull request Oct 11, 2021
* Only do one massive send for all gauge distribution

* Fix all the tests
ValarDragon added a commit that referenced this pull request Oct 13, 2021
* Only do one massive send for all gauge distribution

* Fix all the tests
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants